On Jan 31, 2011, at 12:12 PM, Jörg Schaible wrote: > Hi Jacopo, > > Jacopo Cappellato wrote: > >> I would like to fix some of the code formatting inconsistencies in the >> classes commons-csv, starting with indentation: most of the classes use >> the 4-blanks unit for indentation but CSVParser, CSVPrinter and >> ExtendedBufferedReader use a 2-blanks unit; there are also some >> inconsistencies within the same class. Is it ok if I apply to all of them >> 4-blanks unit for indentation? I know that each project in Commons can >> adopt a different formatting convention, but since in commons-csv there is >> some confusion, do we have a generic guideline for this? > > http://wiki.apache.org/commons/CodeStyle > > If you follow this, there should be no complaints - in general at least ;-) >
Thank you Jörg! > BTW: If you apply a patch, simply resolve(*) or close the issue. Unfortunately I don't think I have karma to do this. Jacopo > > *) My personal preference, there's no consensus. I am closing normally when > the component is finally released. > > - Jörg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
