On 4 March 2011 13:30, <scolebou...@apache.org> wrote: > Author: scolebourne > Date: Fri Mar 4 13:30:35 2011 > New Revision: 1077934 > > URL: http://svn.apache.org/viewvc?rev=1077934&view=rev > Log: > Document mutability of UTC constant, which isn't ideal > > Modified: > > commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java > > Modified: > commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java > URL: > http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java?rev=1077934&r1=1077933&r2=1077934&view=diff > ============================================================================== > --- > commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java > (original) > +++ > commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateUtils.java > Fri Mar 4 13:30:35 2011 > @@ -54,6 +54,8 @@ public class DateUtils { > > /** > * The UTC time zone (often referred to as GMT). > + * Since a {@code TimeZone} is mutable and this is a "constant", it is > + * essential that this object is not altered. > */ > public static final TimeZone UTC_TIME_ZONE = TimeZone.getTimeZone("GMT"); > /**
AFAICT, it's not used within Lang3 - so why don't we just delete it ? Does it really offer much benefit, given the drawback of malicious or accidental corruption? --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
