On 19 April 2011 15:27, Stefan Bodewig <bode...@apache.org> wrote: > On 2011-04-19, sebb wrote: > >> On 19 April 2011 06:39, <bode...@apache.org> wrote: > >>> URL: >>> http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java?rev=1094857&r1=1094856&r2=1094857&view=diff >>> ============================================================================== >>> --- >>> commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java >>> (original) >>>>>> commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java >>>>>> Tue Apr 19 05:39:38 2011 >>> @@ -198,6 +198,7 @@ public class ZipFile { >>> } finally { >>> if (!success) { >>> try { >>>> closed = true; >>> archive.close(); > >> Possibly should call close() here insted of duplicating its code? > > That's inside the constructor, ZipFile is non-final and neither is > close() - I'd trade the two-line duplication for not breaking backwards > compatibility.
Good point re non-final/ctor. > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
