This code in BigFraction.add looks dangerous to me:

 if (ZERO.equals(fraction)) {
            return this;
 }

subtract has similar code and some other methods return the static
BigFraction.ZERO.

While BigFractions are Immutable, this could cause problems for
applications that are expecting new instances resulting from
arithmetic operations.  Can anyone see any reason that this should
not be changed to consistently create new instances?

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to