Le 20/07/2011 18:56, Greg Sterijevski a écrit :
Having discovered the check-results.xml file, I will work through them
all... (the ones I contributed). -Greg
You may also want to have a look at the findbugs report. There are only
a few problems (2 or 3 if I remember correctly), related to storage of
array references. such problems are often solved by using the clone()
method on arrays, to make sure the array stored in the class and the
array seen by the caller are independent to each other.
Thanks for your efforts
Luc
On Wed, Jul 20, 2011 at 10:27 AM, Greg Sterijevski
<[email protected]>wrote:
Yes, sorry about the mess I created. I will go back and add the javadoc.
-Greg
On Wed, Jul 20, 2011 at 8:58 AM, Phil Steitz<[email protected]>wrote:
Ack. All of the warnings are either missing javadoc or exception string
warnings. I was holding off fixing the latter until we had a couple of
impls to compare so we could see the full range of errors we were likely to
see. I can probably do that now, though. Will add to the thread on
regression API refactoring and get something at least functional into the
code. As for the javadoc, thanks for volunteering, Greg :)
On Jul 20, 2011, at 5:03 AM, Luc Maisonobe<[email protected]> wrote:
Hello all,
Is seems there are many checkstyle and findbugs warnings in the
RegressionResults and MillerUpdatingRegression classes. They are mainly
missing javadoc, but also hard-coded exception messages and storing array
references in classes.
Greg, I think you provided the patch, could you have a look at this ?
Luc
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
