Not a blocker, but why not also fix the issues reported by PMD? Gary
On Thu, Oct 20, 2011 at 10:45 AM, Gary Gregory <garydgreg...@gmail.com>wrote: > Hi All: > > Since the async query runner is new, could we give it 100% code coverage? > > What about the FindBugs bug reported? > > Gary > > > On Wed, Oct 19, 2011 at 4:38 PM, Simone Tripodi > <simonetrip...@apache.org>wrote: > >> Hi all guys, >> I'm writing to (re)call for a vote to release apache >> commons-dbutils-1.4 based on RC3. >> >> Please take in consideration that Checkstyle violations cannot be >> fixed due to retro-compatibility issue. >> Clirr error is a false positive, missing complained field is in the >> superclass with protected visibility. >> >> The vote will stay open for 72 hours anc closes on Saturday 22th, at >> 8:40pm CET. >> >> Many thanks in advance for reviewing, have a nice day! >> All the best, >> Simo >> >> Release notes: >> >> >> http://people.apache.org/builds/commons/dbutils/1.4/RC3/RELEASE-NOTES.txt >> >> Tag: >> >> >> https://svn.apache.org/repos/asf/commons/proper/dbutils/tags/DBUTILS_1_4_RC3 >> >> Site: >> >> http://people.apache.org/builds/commons/dbutils/1.4/RC3/site/ >> >> Binaries: >> >> http://people.apache.org/builds/commons/dbutils/1.4/RC3/binaries/ >> >> Maven Artifacts >> >> http://people.apache.org/builds/commons/dbutils/1.4/RC3/staged/ >> >> [ ] +1 release it >> [ ] +0 go ahead I don't care >> [ ] -1 no, do not release it because... (please explain why) >> >> http://people.apache.org/~simonetripodi/ >> http://simonetripodi.livejournal.com/ >> http://twitter.com/simonetripodi >> http://www.99soft.org/ >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
