Hi Gary!
That is the same I wondered: if 6 are "too many", how many are enough? :)
Maybe it's time PMD updates its rules? :P
About the other PMD violations:
`Avoid unused private methods such as 'npeSafeCast(Object)'` is not
true, it is used:
2624 public <T> T peek()
2625 {
2626 try
2627 {
2628 return this.<T> npeSafeCast( stack.peek() );
2629 }
2630 catch ( EmptyStackException e )
2631 {
2632 log.warn( "Empty stack (returning null)" );
2633 return ( null );
2634 }
2635 }
`Overriding method merely calls super` is not true, it returns a
method chain that involves the super:
49 @Override
50 protected LinkedRuleBuilder forPattern( String pattern )
51 {
52 return super.forPattern( pattern ).withNamespaceURI( namespaceURI );
53 }
`Avoid empty catch blocks` is the same that we have in IO:
77 try
78 {
79 if ( s != null )
80 {
81 s.close();
82 }
83 }
84 catch ( IOException e )
85 {
86 // close quietly
87 }
Thanks for reviewing, hope this clarifies and you will express a +1 :P
All the best,
Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/
On Tue, Oct 25, 2011 at 11:24 PM, Gary Gregory <[email protected]> wrote:
> Hi Simo,
>
> Not blockers but the PMD issues could be addressed except:
>
> Should we turn off "Too many static imports may lead to messy code"? How
> many is too many?
>
> Gary
>
> On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi
> <[email protected]>wrote:
>
>> Hi all guys,
>> I'm writing to call for a vote to release apache commons-digester-3.1
>> based on RC2.
>>
>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE
>> call.
>> Please take in consideration that broken 3.1 links will be fixed once
>> the site will be deployed.
>>
>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm
>> CET.
>>
>> Many thanks in advance for reviewing, have a nice day!
>> All the best,
>> Simo
>>
>> Release notes:
>>
>>
>> http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>
>> Tag:
>>
>>
>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>
>> Site:
>>
>> http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>
>> Binaries:
>>
>> http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>
>> Maven Artifacts (staged on Nexus)
>>
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>
>> [ ] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because... (please explain why)
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>>
>
>
> --
> E-Mail: [email protected] | [email protected]
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
