I committed a small refactoring. Please comment and/or continue refactoring.
Thank you, Gary On Mon, Jan 23, 2012 at 11:38 AM, sebb <seb...@gmail.com> wrote: > On 23 January 2012 15:27, Gary Gregory <garydgreg...@gmail.com> wrote: > > On Mon, Jan 23, 2012 at 10:11 AM, Niall Pemberton < > niall.pember...@gmail.com > >> wrote: > > > >> I find the behaviour of FileUtils.directoryContains() method very > >> strange that it would return true for a file that doesn't exist. Since > >> this is a new method that will be released for the first time in the > >> next release, then it would be preferable to either move it to > >> FilenameUtils or change its behaviour before releasing: > > +1 > > >> > > > > I think that, based on the initial request, we should move the method to > > FilenameUtils and keep the behavior. > > Fine by me. > > > The parameters would need to change from File to String. > > OK by me. > > > Thoughts? > > > > Gary > > > > > > > >> https://issues.apache.org/jira/browse/IO-291 > >> > >> Niall > >> > >> On Mon, Jan 23, 2012 at 11:43 AM, Gary Gregory <garydgreg...@gmail.com> > >> wrote: > >> > Hi All, > >> > > >> > Is trunk ready for a 2.2? It feels to me like we have a nice small > >> > increment in functionality to release (RERO). > >> > > >> > Gary > >> > > >> > -- > >> > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > >> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > >> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > >> > Blog: http://garygregory.wordpress.com > >> > Home: http://garygregory.com/ > >> > Tweet! http://twitter.com/GaryGregory > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
