Salut Luc, thanks for reviewing! I am personally worried to fix the findbugs errors and break the backward compatibility, I'll ask Nick's help!
Anyway, no issues from my side to cut out an improved RC!! A trés bientôt! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Feb 1, 2012 at 10:21 AM, Luc Maisonobe <luc.maison...@free.fr> wrote: > Le 30/01/2012 19:18, Gary Gregory a écrit : >> -0: >> >> The text in RELEASE-NOTES.txt contradicts itself: >> >> First we say: >> " >> IMPORTANT NOTES >> ================ >> >> BREAKING CHANGES: >> >> * NONE. >> " >> >> Then at the end we say: >> >> " >> OTHER NOTES >> ============ >> >> Users should be aware of the following potential issues with migration: >> >> * The protected method validator.EmailValidator.isValidIpAddress() >> previously >> exposed a Jakarta ORO class via its signature. The signature has been >> modified to accept a a java.lang.String and is not therefore not >> compatible. >> However, this class is deprecated and clients should use the equivalent >> class in the validator.routines package. >> >> * Invocations of the method GenericValidator.matchRegexp() should be >> inspected >> for semantic differences between Jakarta ORO and Java regular expressions. >> " >> >> The release is therefore binary incompatible (a "BREAKING" change) for the >> first reason and semantically incompatible for the second (a different kind >> of "BREAKING" change). This should be filed under "IMPORTANT" IMO, not an >> "OTHER" note. >> >> Not blockers, but should be fixed (easy): >> >> Checkstyle: 4 x "Expected @param tag for ..." > > I agree, these one are non-blockers. > >> >> Then these are unknown as to blockers: 2 findbugs issues: >> >> Inconsistent synchronization of >> org.apache.commons.validator.ValidatorAction.jsFunction; locked 62% of time >> MT_CORRECTNESSIS2_INCONSISTENT_SYNC<http://findbugs.sourceforge.net/bugDescriptions.html#IS2_INCONSISTENT_SYNC> >> 348MediumClass org.apache.commons.validator.ValidatorAction defines >> non-transient non-serializable instance field validationMethodBAD_PRACTICE >> SE_BAD_FIELD<http://findbugs.sourceforge.net/bugDescriptions.html#SE_BAD_FIELD>Not >> availableHigh > > I'm not sure either about these issues. Simone, could you check if they > are worht another RC or not ? > I'll cast my vote according to your answer about these issues. > > thanks > Luc > >> Gary >> >> On Sun, Jan 29, 2012 at 8:59 AM, Simone Tripodi >> <simonetrip...@apache.org>wrote: >> >>> Hi all again mates :) >>> >>> after the failing RC1, I open the VOTE for Apache Commons validator >>> 1.4.0 based on RC2. Follow details: >>> >>> Tag: >>> >>> >>> https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/ >>> >>> Release notes: >>> >>> >>> http://people.apache.org/builds/commons/validator/1.4.0/RC2/RELEASE-NOTES.txt >>> >>> Site: >>> >>> http://people.apache.org/builds/commons/validator/1.4.0/RC2/site/ >>> (broken links in the sidebar will be fixed once the site will be >>> redeployed) >>> >>> Binaries: >>> >>> http://people.apache.org/builds/commons/validator/1.4.0/RC2/binaries/ >>> >>> Maven Artifacts >>> >>> https://repository.apache.org/content/repositories/orgapachecommons-153 >>> >>> [ ] +1 release it >>> [ ] +0 go ahead I don't care >>> [ ] -0 not blocking, but... >>> [ ] -1 no, do not release it because... >>> >>> Many thanks in advance for reviewing, all the best and have a nice day! >>> -Simo >>> >>> http://people.apache.org/~simonetripodi/ >>> http://simonetripodi.livejournal.com/ >>> http://twitter.com/simonetripodi >>> http://www.99soft.org/ >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
