Hi Simo,
please have a look at my comments inline.
Am 27.02.2012 08:28, schrieb Simone Tripodi (Commented) (JIRA):
[
https://issues.apache.org/jira/browse/SANDBOX-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217086#comment-13217086
]
Simone Tripodi commented on SANDBOX-397:
----------------------------------------
I still haven't had the time to take a look at your patches, we didn't even
agree on the proposed design that you already tracked all the roadmap? What if
I don't agree on one of the the proposed modifications?
Not not sure what you trying to say. Do you feel uncomfortable, because
I wrote those patches without discussing it first? Or are you afraid,
that I get the feeling that I wasted my time, if you disagree with my
proposed changes?
As you said, it is just a proposal. Even if I had write access to the
svn I wouldn't have commited such a big change without discussing it. I
had some spare time this weekend so I just wanted to try my ideas out. I
guess a patch is a better basis for discussion than just outlining what
I had in mind (you can see it the other way around: I had an idea I
wanted to discuss, so I wrote a patch). If you disagree with (parts) of
the modifications, I'll just adjust the patch and submit it again.
If you are worried about my spare time, let me just say it was just fun
working with the source. Even if you don't like the patch, that is no
problem for me. I'm not offended or something. :)
_I think it is the right thing to do_ doesn't mean that *it is*.
That is why I wrote "I think" ;)
I'll let you know as soon as I get the chance to have a look at your patches,
and provide you feedbacks.
TIA!
Benedikt
[BeanUtils2] Replace NullPointerExceptions been thrown in DefaultBeanAccessor
with NoSuchMethodEceptions
--------------------------------------------------------------------------------------------------------
Key: SANDBOX-397
URL: https://issues.apache.org/jira/browse/SANDBOX-397
Project: Commons Sandbox
Issue Type: Task
Components: BeanUtils2
Affects Versions: Nightly Builds
Reporter: Benedikt Ritter
Attachments: SANDBOX-397.txt, SANDBOX-397_SRP.txt,
SANDBOX-397_SRPv2.txt
At the moment, methods in {{DefaultBeanAccessor}} throw a
{{NullPointerException}}, if no {{PropertyDescriptor}} for a given property
name can be retrieved. As discussed on the ML (see
http://markmail.org/thread/zlehclmybp5xgn5n) this behavior should be changed to
throwing {{NoSuchMethodException}}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
