Re: [configuration] Replace DatabaseConfiguration with version from branch?

[Emmanuel Bourg]

I reviewed the class on the branch, I'm probably biased but I found the original version easier to read despite the clever use of the JdbcOperation class to avoid code duplications. I also noticed that the internal classes increased the size of the code by a 2.5 factor in the final jar (+6K).

Emmanuel Bourg



Le 01/03/2012 22:03, Oliver Heger a écrit :

This is not an objection, this class will have to be redesigned completely in the future to support caching anyway. So both implementations will probably be obsolete eventually.

Hi,

the version of DatabaseConfiguration in the experimental branch strongly
differs from the trunk version. It uses a template approach for
executing JDBC operations thus avoiding the complex JDBC exception
handling plumbing code.

I prefer this style because IMHO it makes the implementations of the
operations clearer and more readable. So are there any objections
against replacing the trunk version?

Oliver

smime.p7s
Description: S/MIME Cryptographic Signature