On Sun, Mar 18, 2012 at 1:08 PM, Oliver Heger
<oliver.he...@oliver-heger.de>wrote:
> Hi Gary,
>
Hi Oliver,
Thank you for your review. I'll cancel this VOTE. More below.
>
> when checking the RC I found some minor things. None of them is blocking
> IMO. Here is the list:
>
> The release notes could be improved:
> - The statement "The Commons IO library contains utility classes, stream
> implementations, file filters, file comparators and endian classes." is
> repeated twice (with minor differences).
>
- There is an unresolved macro "$release.description.**replaceAll(" ", "")"
>
I've clean that up in the txt file. I do not understand why we now have a
src/changes/release-notes.vm, more Maven black magic I presume. I am not
touching the vm file now.
- I am missing a comment about binary compatibility.
>
Added.
> When testing the ant build (Windows 7, Java 1.5) I get a problem with a
> failing test case:
> ant test
> gives:
> BUILD FAILED
> D:\data\projects\OpenSource\**io\commons-io-2.2-src\build.**xml:185: Test
> org.apache.commons.io.**FileUtilsTestCase failed
>
> The relevant content of the surefire report looks as follows:
> Testcase: testContentEqualsIgnoreEOL took 0,031 sec
> FAILED
> null
> junit.framework.**AssertionFailedError
> at org.apache.commons.io.**FileUtilsTestCase.**
> testContentEqualsIgnoreEOL(**FileUtilsTestCase.java:578)
>
Works fine for me with:
Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500)
Maven home: C:\Java\apache-maven-3.0.4\bin\..
Java version: *1.5.0_22*, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.5.0_22\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500)
Maven home: C:\Java\apache-maven-3.0.4\bin\..
Java version: *1.6.0_31*, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_31\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500)
Maven home: C:\Java\apache-maven-3.0.4\bin\..
Java version: *1.7.0_03*, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_03\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> However, the maven build is successful.
>
> Regarding the site:
> - Any idea why the success rate in the surefire report is only 99.891%?
> (My local build resulted in 100%)
>
Nope :(
> - The Checkstyle link appears twice.
>
That's a Maven or Checkstyle issue. One is supposed to be an aggregate
report.
- There are 29 some Findbugs errors
>
FindBugs was updated to 2.0.0 from 1.3.9 and finds more issues. The
majority (using the platform encoding) is part of our API and we cannot
change with breaking compatibility. Other issues I am not sure how to deal
with for now but should not hold up a release IMO. It is good that they are
out in the open though.
Gary
> Oliver
>
> PS: I will be offline next week, so won't be able to respond.
>
> Am 18.03.2012 04:53, schrieb Gary Gregory:
>
> Hello All:
>>
>> This is a VOTE to release Commons IO 2.2-RC2
>>
>> The changes from RC1 are:
>>
>> - Built from tag
>> - Update release notes with version 2.2
>> - Update notice file with 2012 copyright
>> - Update @version with $Id$
>> - Update site to link to only Javadoc 2.2 and 1.x.
>>
>> This VOTE is open for at least 72 hours until March 20 2012 at 23:55 EST.
>>
>> The files:
>>
>> https://repository.apache.org/**content/repositories/**
>> orgapachecommons-086/<https://repository.apache.org/content/repositories/orgapachecommons-086/>
>>
>> The tag:
>>
>> https://svn.apache.org/repos/**asf/commons/proper/io/tags/2.**2-RC2<https://svn.apache.org/repos/asf/commons/proper/io/tags/2.2-RC2>
>>
>> The site:
>>
>> https://people.apache.org/**builds/commons/commons-io/2.2/**RC2/<https://people.apache.org/builds/commons/commons-io/2.2/RC2/>
>>
>> New features:
>> o Use terabyte (TB) , petabyte (PB) and exabyte (EB) in
>> FileUtils.**byteCountToDisplaySize(long size) Issue: IO-287. Thanks to
>> Ron
>> Kuris, Gary Gregory.
>> o FileUtils.listFiles() doesn't return directories Issue: IO-173. Thanks
>> to Marcos VinÃcius da Silva.
>> o CharSequenceInputStream to efficiently stream content of a CharSequence
>> Issue: IO-297. Thanks to Oleg Kalnichevski.
>> o The second constructor of Tailer class does not pass 'delay' to the
>> third
>> one Issue: IO-304. Thanks to liangly.
>> o TeeOutputStream does not call branch.close() when main.close() throws an
>> exception Issue: IO-303. Thanks to fabian.barney.
>> o ArrayIndexOutOfBoundsException in BOMInputStream when reading a file
>> without BOM multiple times Issue: IO-302. Thanks to jsteuerwald, detinho.
>> o Add IOUtils.closeQuietly(Selector) necessary Issue: IO-301. Thanks to
>> kaykay.unique.
>> o IOUtils.closeQuietly() should take a ServerSocket as a parameter Issue:
>> IO-292. Thanks to sebb.
>> o Add read/readFully methods to IOUtils Issue: IO-290. Thanks to sebb.
>> o Supply a ReversedLinesFileReader Issue: IO-288. Thanks to Georg
>> Henzler.
>> o Add new function FileUtils.directoryContains. Issue: IO-291. Thanks to
>> ggregory.
>> o FileUtils.contentEquals and IOUtils.contentEquals - Add option to ignore
>> "line endings"
>> Added contentEqualsIgnoreEOL methods to both classes Issue:
>> IO-275. Thanks to CJ Aspromgos.
>>
>> Fixed Bugs:
>> o FileUtils.**moveDirectoryToDirectory removes source directory if
>> destination is a subdirectory Issue: IO-300.
>> o ReaderInputStream#read(byte[] b, int off, int len) should check for
>> valid
>> parameters Issue: IO-307.
>> o ReaderInputStream#read(byte[] b, int off, int len) should always return
>> 0
>> for length == 0 Issue: IO-306.
>> o "FileUtils#**deleteDirectoryOnExit(File)" does not work Issue: IO-276.
>> Thanks to nkami.
>> o BoundedInputStream.read() treats max differently from
>> BoundedInputStream.read(byte[]**...) Issue: IO-273. Thanks to sebb.
>> o Various methods of class 'org.apache.commons.io.**FileUtils'
>> incorrectly
>> suppress 'java.io.IOException' Issue: IO-298. Thanks to Christian
>> Schulte.
>>
>> Changes:
>> o ReaderInputStream optimization: more efficient reading of small chunks
>> of
>> data Issue: IO-296. Thanks to Oleg Kalnichevski.
>>
>> Thank you,
>> Gary
>>
>>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail:
> dev-unsubscribe@commons.**apache.org<dev-unsubscr...@commons.apache.org>
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
