Hi,
There are a few checkstyle errors in [functor] trunk code regarding
tabs, missing space after an if statement and after (cast)ing a
variable. I've attached a simple patch for it. I will file an issue for
and will attach this patch there if there is no objection :)
And three new TODO's were included in [functor] since last call for
votes. All of them in tests for aggregators. How is it handled? An issue
must be filed, someone will take care of it before the new call for
votes happens, or are TODOs in tests ignored?
Thanks,
--
Bruno P. Kinoshita
http://www.kinoshita.eti.br
http://www.tupilabs.com
Index: src/main/java/org/apache/commons/functor/core/Offset.java
===================================================================
--- src/main/java/org/apache/commons/functor/core/Offset.java (revision 1346720)
+++ src/main/java/org/apache/commons/functor/core/Offset.java (working copy)
@@ -31,14 +31,14 @@
* @version $Revision$ $Date$
*/
public final class Offset implements Predicate, UnaryPredicate<Object>, BinaryPredicate<Object, Object>, Serializable {
- // static attributes
+ // static attributes
// ------------------------------------------------------------------------
/**
- * serialVersionUID declaration.
- */
- private static final long serialVersionUID = 5800706757874735854L;
+ * serialVersionUID declaration.
+ */
+ private static final long serialVersionUID = 5800706757874735854L;
- // instance variables
+ // instance variables
//---------------------------------------------------------------
/**
* The number of times the predicate must return {@code false}.
@@ -91,14 +91,14 @@
*/
@Override
public boolean equals(Object obj) {
- if(obj == this) {
- return true;
- }
- if(!(obj instanceof Offset)) {
- return false;
- }
- Offset other = (Offset)obj;
- return other.min == min;
+ if (obj == this) {
+ return true;
+ }
+ if (!(obj instanceof Offset)) {
+ return false;
+ }
+ Offset other = (Offset) obj;
+ return other.min == min;
}
/**
@@ -106,10 +106,10 @@
*/
@Override
public int hashCode() {
- int result = "Offset".hashCode();
- result <<= 2;
- result ^= min;
- return result;
+ int result = "Offset".hashCode();
+ result <<= 2;
+ result ^= min;
+ return result;
}
/**
Index: src/main/java/org/apache/commons/functor/core/Limit.java
===================================================================
--- src/main/java/org/apache/commons/functor/core/Limit.java (revision 1346720)
+++ src/main/java/org/apache/commons/functor/core/Limit.java (working copy)
@@ -32,13 +32,13 @@
* @version $Revision$ $Date$
*/
public final class Limit implements Predicate, UnaryPredicate<Object>, BinaryPredicate<Object, Object>, Serializable {
- // static attributes
+ // static attributes
// ------------------------------------------------------------------------
/**
- * serialVersionUID declaration.
- */
- private static final long serialVersionUID = 8974528922587619067L;
- // instance variables
+ * serialVersionUID declaration.
+ */
+ private static final long serialVersionUID = 8974528922587619067L;
+ // instance variables
//---------------------------------------------------------------
/**
* The max number of times the predicate can be invoked.
@@ -91,14 +91,14 @@
*/
@Override
public boolean equals(Object obj) {
- if(obj == this) {
- return true;
- }
- if(!(obj instanceof Limit)) {
- return false;
- }
- Limit other = (Limit)obj;
- return other.max == max;
+ if (obj == this) {
+ return true;
+ }
+ if (!(obj instanceof Limit)) {
+ return false;
+ }
+ Limit other = (Limit) obj;
+ return other.max == max;
}
/**
@@ -106,10 +106,10 @@
*/
@Override
public int hashCode() {
- int result = "Limit".hashCode();
- result <<= 2;
- result ^= max;
- return result;
+ int result = "Limit".hashCode();
+ result <<= 2;
+ result ^= max;
+ return result;
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
