On 28 June 2012 13:10, <ggreg...@apache.org> wrote: > Author: ggregory > Date: Thu Jun 28 12:10:27 2012 > New Revision: 1354966 > > URL: http://svn.apache.org/viewvc?rev=1354966&view=rev > Log: > Fix file permission test when not on Windows. > > Modified: > commons/proper/vfs/trunk/core/pom.xml > > commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java > commons/proper/vfs/trunk/pom.xml > > Modified: commons/proper/vfs/trunk/core/pom.xml > URL: > http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/pom.xml?rev=1354966&r1=1354965&r2=1354966&view=diff > ============================================================================== > --- commons/proper/vfs/trunk/core/pom.xml (original) > +++ commons/proper/vfs/trunk/core/pom.xml Thu Jun 28 12:10:27 2012 > @@ -81,6 +81,11 @@ > <artifactId>junit</artifactId> > <scope>test</scope> > </dependency> > + <dependency> > + <groupId>org.apache.commons</groupId> > + <artifactId>commons-lang3</artifactId> > + <scope>test</scope> > + </dependency> > <!-- Test FTP with Apache FTP Server (MINA) --> > <dependency> > <groupId>org.apache.ftpserver</groupId> > > Modified: > commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java > URL: > http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java?rev=1354966&r1=1354965&r2=1354966&view=diff > ============================================================================== > --- > commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java > (original) > +++ > commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/local/test/PermissionsTests.java > Thu Jun 28 12:10:27 2012 > @@ -18,6 +18,8 @@ package org.apache.commons.vfs2.provider > > import junit.framework.Assert; > > +import org.apache.commons.lang3.SystemUtils; > + > import org.apache.commons.vfs2.FileObject; > import org.apache.commons.vfs2.test.AbstractProviderTestCase; > > @@ -32,7 +34,7 @@ public class PermissionsTests extends Ab > public void testFolderIsExecutable() throws Exception > { > final FileObject folder = > this.getReadFolder().resolveFile("file1.txt"); > - Assert.assertTrue(folder.isExecutable()); > + Assert.assertEquals(SystemUtils.IS_OS_WINDOWS, > folder.isExecutable());
Seems like overkill to use Commons Lang just for this one line. Yes, it's only a test dependency, but still. > } > > } > > Modified: commons/proper/vfs/trunk/pom.xml > URL: > http://svn.apache.org/viewvc/commons/proper/vfs/trunk/pom.xml?rev=1354966&r1=1354965&r2=1354966&view=diff > ============================================================================== > --- commons/proper/vfs/trunk/pom.xml (original) > +++ commons/proper/vfs/trunk/pom.xml Thu Jun 28 12:10:27 2012 > @@ -370,6 +370,12 @@ > <version>4.10</version> > <scope>test</scope> > </dependency> > + <dependency> > + <groupId>org.apache.commons</groupId> > + <artifactId>commons-lang3</artifactId> > + <version>3.1</version> > + <scope>test</scope> > + </dependency> > <!-- Test FTP with Apache FTP Server (MINA) --> > <dependency> > <groupId>org.apache.ftpserver</groupId> > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
