Hi Elijah, great news, thanks a lot! Since everybody will be watching the football match on TV but I don't mind at all, I'll take advantage to have a look at the patch :)
I'll let you know ASAP! best, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Thu, Jun 28, 2012 at 8:53 PM, Elijah Zupancic <eli...@zupancic.name> wrote: > I've finally completed the work on updating chain v2 to fix Checkstyle > / PMD violations. It wasn't advisable to fix all of the issues, but I > have fixed the major ones. As a side note, I've intentionally left off > the javadocs for the example code that is used in the cookbook. > > Please see the attached diff here: > https://issues.apache.org/jira/browse/CHAIN-69 > > On Mon, Apr 16, 2012 at 1:59 AM, Simone Tripodi > <simonetrip...@apache.org> wrote: >> Thanks a lot for the followup Elijah, that was something I was waiting for! >> :) >> >> I'll have a look at the issue tonight, stay tuned! >> >> Thanks and all the best, >> -Simo >> >> http://people.apache.org/~simonetripodi/ >> http://simonetripodi.livejournal.com/ >> http://twitter.com/simonetripodi >> http://www.99soft.org/ >> >> >> >> On Mon, Apr 16, 2012 at 3:59 AM, Elijah Zupancic <eli...@zupancic.name> >> wrote: >>> I've just finished work on updating the cookbook for the generics api. >>> Please see the patch attached to the following issue: >>> https://issues.apache.org/jira/browse/CHAIN-66 >>> >>> * Code examples in the cookbook have been added to the >>> apps/cookbook-examples project. >>> * I did not update the struts examples because I know nothing about struts. >>> * The example project does not build automatically as part of the main >>> build. >>> * I did not do the conversion from the source cookbook.xml to its >>> intended output format. Although, it looks like an already converted >>> version is checked into source control. >>> * I updated the main pom so that it references the correct >>> checkstyle.xml rather than throw an error. >>> * I can't get the maven site to build, so if anyone wants to help with >>> that it will be appreciated. >>> >>> Thanks, >>> -Elijah >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
