On Mon, Jul 30, 2012 at 5:21 PM, Liviu Tudor <liviu.tu...@gmail.com> wrote:
> Mark/Gary/Seb, > > Just to clarify this: I haven't touched at all the 1.5 branch -- all of > these refer strictly to the 1.6 branch (which uses JDK 1.5 according to > the pom and also uses Junit 4.10). > > So in the light of these, should I: > > 1/ also apply these patches to the 1.5 branch? > Up to you. > 2/ downgrade junit to 3.8.2 on the 1.6 branch? > I do not think so, this branch is for Java >= 1.5. Why? Does JUnit 4.10 not run on Java 5? Gary > > Regards, > > > Liv > > Liviu Tudor > > E: liviu.tu...@gmail.com > C: +1 650-2833815 (USA) > M: +44 (0)7591540313 (UK, Europe) > W: http://about.me/liviutudor > Skype: liviutudor > > I'm nobody, nobody's perfect -- therefore I'm perfect! > > > > > > > > On 30/07/2012 14:15, "sebb" <seb...@gmail.com> wrote: > > >>> > >>>* Last but not the least, I see the pom references junit-4.10 but the > >>>unit > >>>tests are still based on the old junit-3.8 looking at it. Worth to > >>>change > >>>these to annotations a la junit-4? > >> > >>Not for Pool 1.5. The target Java version is < 1.5. > > > >In which case, it should not be using JUnit 4.10, which does not run > >on Java 1.4; the most recent JUnit for Java 1.4 is 3.8.2. > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory