The @since tag is wrong and there is no unit test. The feature is trivial so it is likely not worth going round on the patch and some one should just add the feature.
Gary On Sep 1, 2012, at 20:19, Olloth <[email protected]> wrote: > GitHub user Olloth opened a pull request: > > https://github.com/apache/commons-lang/pull/2 > > Update src/main/java/org/apache/commons/lang3/SystemUtils.java > > Updated SystemUtils to account for Windows 8. > > Windows 8 RTM is released, soon to be going out to consumers. Many people > are already using it. > > The current version is 6.2.9200.16384 (RTM) and the string returned by the > java property is "Windows 8" in accordance with 7 and other versions. > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/Olloth/commons-lang patch-1 > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/commons-lang/pull/2.patch > > ---- > commit f39454442d3baee7ff7473d9251bbf13f1a0113a > Author: Dalton J Pelc <[email protected]> > Date: 2012-09-01T17:17:24-07:00 > > Update src/main/java/org/apache/commons/lang3/SystemUtils.java > > Updated SystemUtils to account for Windows 8. > > ---- > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
