On 12/16/2012 06:43 PM, Phil Steitz wrote: > Artifacts look good. > Sigs are good, key is in KEYS. > > Following are blockers IMO: > > 1) I am getting the test failures below though, running under: > > Apache Maven 2.2.1 (r801777; 2009-08-06 12:16:01-0700) > Java version: 1.6.0_37 > Java home: > /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x" version: "10.7.5" arch: "x86_64" Family: "mac"
this has already been observed by other people before, and it is most likely related to a buggy DNS server in your environment. The unit tests try resolve an invalid url (http://example.invalid), which seems to succeed in your case. You can test it yourself by typing the url in your browser. I am already in favor of changing the unit test to prevent such issues again in the future, but imho this is not blocking a release. > 2) There are missing @since tags for the methods added to the Email > class. > > Not a blocker, but should be fixed: > > 3) Release notes refer to obsolete Sun URLs. These (sadly, > typically) redirect to pages of no real value in finding the > artifacts that they used to point to. I would drop the URLs and > reference to Sun. I will fix the other things. Thanks, Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
