-1 Per issue MATH-902:
Its hard for me to read all the code, but at first pass it seems that in BOBYQAOptimizer, maybe for others, no convergence criterion is set. So there is actually no way to set the maximum number of iterations. On that note. The optimization data is parsed at runtime, which is bad because it leads to error prone code, since the user cannot tell that he is passing an option that is ignored (or incorrect) until that line is actually executed during runtime. In addition, if he is passing multiple options of the same base class, something that is hard to notice unless you go down the hierarchy tree for all your input classes, only the last option is actually set, without any exception or warning given to the user. On Dec 18, 2012, at 12:49 PM, Gilles Sadowski <gil...@harfang.homelinux.org> wrote: > Hi. > > Method "getCovariances()" in > org.apache.commons.math3.optimization.general.AbstractLeastSquaresOptimizer > return incorrect values, when called from an instance of > org.apache.commons.math3.optimization.general.LevenbergMarquardtOptimizer > This has been broken (by me) during the clean-up of the latter, where I > failed to keep a (deprecated) "protected" field updated.[1] > [This mistake was not caught by the CM unit test suite...] > > I'll commit the fix and create a new tag. > > > Regards, > Gilles > > [1] Bitten by the equivalent of the "global" variables of old. :-{ > > > On Mon, Dec 17, 2012 at 09:41:48PM +0100, Gilles Sadowski wrote: >> Hi. >> >> Please have a look at the Commons Math 3.1 release candidate.[1] >> >> ---------- >> Tag: >> https://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_3_1_RC2/ >> >> Site: >> http://people.apache.org/builds/commons/math/3.1/RC2/ >> >> Binaries: >> >> https://repository.apache.org/content/repositories/orgapachecommons-041/org/apache/commons/commons-math3/3.1/ >> >> [ ] +1 Release it. >> [ ] +0 Go ahead; I don't care. >> [ ] -0 There are a few minor glitches: ... >> [ ] -1 No, do not release it because ... >> >> This vote will close in 72 hours. >> ---------- >> >> >> Thanks, >> Gilles >> >> [1] This third attempt provides all the distribution files. The tag was >> unchanged (MATH_3_1_RC2). >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org