On Dec 21, 2012, at 4:18, Thomas Neidhart <thomas.neidh...@gmail.com> wrote:
> On Thu, Dec 20, 2012 at 11:26 AM, Gilles Sadowski < > gil...@harfang.homelinux.org> wrote: > >> Hi. >> >> Please have a look at the next candidate (RC5), and vote for the release >> of Commons Math 3.1. >> >> ---------- >> Tag: >> https://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_3_1_RC5/ >> >> Site: >> http://people.apache.org/builds/commons/math/3.1/RC5/ >> >> Binaries: >> >> https://repository.apache.org/content/repositories/orgapachecommons-052/org/apache/commons/commons-math3/3.1/ >> >> [ ] +1 Release it. >> [ ] +0 Go ahead; I don't care. >> [ ] -0 There are a few minor glitches: ... >> [ ] -1 No, do not release it because ... >> >> This vote will close in 72 hours. >> ---------- > > Hi, > > this is not yet my vote, just a request for clarification. > > I checked again the Clirr errors, and there are still the two related to > the probability method in LogNormal and NormalDistribution. > > In 3.0, there was a method with only 1 parameter, which always returned 0. > Now there is a probability method with two parameters, which is defined in > the implemented interface AbstractRealDistribution. > > You mentioned that this is a false positive, but I doubt this. Maybe the > probability method was never used, but then it should at least be mentioned > in the release notes. > > Sorry to be pedantic about this. Clirr lists 7 errors, so strictly speaking it does not looks like 3.1 is binary compatible with 3.0. I see these options: 1) document 3.1 as not BC. This is not what we usually do in Commons. 2) fix the clirr errors in the code. This is the safe option. 3) make this a 4.0 releases and change the packages and maven coordinates. This seems like a high price and likely not what the [math] community intends for a real 4.0. Gary > > Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
