On 12 February 2013 21:38, Bruno P. Kinoshita <ki...@apache.org> wrote: >> It looks like functor has not yet been released, so we have free >> choice over groupId (and artifactId). > > Exactly, that's why we're also starting threads about serialization, default > arity, interfaces nomenclature, etc :o) > >> We should use org.apache.commons for the groupId. > > > Done in r1445397. build-tools was also overriding the parent version, so I > removed too. I hope I didn't make any mistakes now.
It only makes sense to default to the component top-level pom if the module pom has the top-level pom as its parent. That is not the case for the build-tools module. I don't know if it's possible to change the parent; if not, there can be no defaulting of groupId etc. > Thanks! > > [1] http://svn.apache.org/viewvc?view=revision&revision=r1445397 > > Bruno P. Kinoshita > http://kinoshita.eti.br > http://tupilabs.com > > > ----- Original Message ----- >> From: sebb <seb...@gmail.com> >> To: Commons Developers List <dev@commons.apache.org> >> Cc: >> Sent: Tuesday, February 12, 2013 7:09 PM >> Subject: Re: svn commit: r1445005 - /commons/proper/functor/trunk/api/pom.xml >> >> On 12 February 2013 21:00, Bruno P. Kinoshita >> <brunodepau...@yahoo.com.br> wrote: >>> Ops, note to self: see the parent pom before posting to the mailing list or >> committing to SVN :) Sorry, I thought commons-functor-parent had already a >> groupId. >>> >>> Let me know what is the best choice then, and I'll update the trunk. >> >> It looks like functor has not yet been released, so we have free >> choice over groupId (and artifactId). >> >> We should use org.apache.commons for the groupId. >> >>> Cheers >>> >>> Bruno P. Kinoshita >>> http://kinoshita.eti.br >>> http://tupilabs.com >>> >>> >>> ----- Original Message ----- >>>> From: Matt Benson <gudnabr...@gmail.com> >>>> To: dev@commons.apache.org >>>> Cc: comm...@commons.apache.org >>>> Sent: Tuesday, February 12, 2013 6:42 PM >>>> Subject: Re: svn commit: r1445005 - >> /commons/proper/functor/trunk/api/pom.xml >>>> >>>> Wait, now I think we're all getting out of sync with one another. >> :) I >>>> can respect Sebastian's point that a Commons component's >> "top" >>>> pom >>>> explicitly declare the groupId, particularly in light of his >> willingness to >>>> omit it from any subordinate modules, so actually the change that >>>> precipitated this whole discussion should stand. The groupId should >> then >>>> be explicitly added to commons-functor-parent, and can be removed from >> any >>>> child modules including build-tools. >>>> >>>> Matt >>>> >>>> >>>> On Mon, Feb 11, 2013 at 6:47 PM, <ki...@apache.org> wrote: >>>> >>>>> Author: kinow >>>>> Date: Tue Feb 12 00:47:23 2013 >>>>> New Revision: 1445005 >>>>> >>>>> URL: http://svn.apache.org/r1445005 >>>>> Log: >>>>> Remove duplicated groupId >>>>> >>>>> Modified: >>>>> commons/proper/functor/trunk/api/pom.xml >>>>> >>>>> Modified: commons/proper/functor/trunk/api/pom.xml >>>>> URL: >>>>> >>>> >> http://svn.apache.org/viewvc/commons/proper/functor/trunk/api/pom.xml?rev=1445005&r1=1445004&r2=1445005&view=diff >>>>> >>>>> >>>> >> ============================================================================== >>>>> --- commons/proper/functor/trunk/api/pom.xml (original) >>>>> +++ commons/proper/functor/trunk/api/pom.xml Tue Feb 12 00:47:23 >> 2013 >>>>> @@ -22,7 +22,6 @@ >>>>> <artifactId>commons-functor-parent</artifactId> >>>>> <version>1.0-SNAPSHOT</version> >>>>> </parent> >>>>> - <groupId>org.apache.commons</groupId> >>>>> <artifactId>commons-functor-api</artifactId> >>>>> <name>Commons Functor API</name> >>>>> <description>Provide the basic APIs</description> >>>>> >>>>> >>>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
