2013/3/15 Simone Tripodi <simonetrip...@apache.org> > checkstyle doesn't complain about it - and this classes are for > internal use only, so I don't pay too much attention on them until > checkstyle is happy. > > feel free to adjust them by yourself if you have spare time. >
See http://svn.apache.org/r1456911 :-) > > http://people.apache.org/~simonetripodi/ > http://simonetripodi.livejournal.com/ > http://twitter.com/simonetripodi > http://www.99soft.org/ > > > On Fri, Mar 15, 2013 at 10:36 AM, Benedikt Ritter <brit...@apache.org> > wrote: > > Hi Simo, > > > > Would be even nicer if every sentence starts with an upper case letter > and > > ends with a period. > > > > Benedikt > > > > 2013/3/15 <simonetrip...@apache.org> > > > >> Author: simonetripodi > >> Date: Fri Mar 15 09:29:30 2013 > >> New Revision: 1456832 > >> > >> URL: http://svn.apache.org/r1456832 > >> Log: > >> checkstyle: Missing a Javadoc comment. > >> > >> Modified: > >> > >> > commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java > >> > >> Modified: > >> > commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java > >> URL: > >> > http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java?rev=1456832&r1=1456831&r2=1456832&view=diff > >> > >> > ============================================================================== > >> --- > >> > commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java > >> (original) > >> +++ > >> > commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java > >> Fri Mar 15 09:29:30 2013 > >> @@ -45,30 +45,49 @@ final class QuotedPrintableDecoder { > >> } > >> } > >> > >> - // default number of characters we will write per line. > >> + /** > >> + * default number of characters we will write per line. > >> + */ > >> private static final int DEFAULT_CHARS_PER_LINE = 76; > >> > >> - // the output stream we're wrapped around > >> + /** > >> + * the output stream we're wrapped around > >> + */ > >> protected OutputStream out; > >> > >> - // the number of bytes written; > >> + /** > >> + * the number of bytes written; > >> + */ > >> protected int bytesWritten = 0; > >> > >> - // number of bytes written on the current line > >> + /** > >> + * number of bytes written on the current line > >> + */ > >> protected int lineCount = 0; > >> > >> - // line length we're dealing with > >> + /** > >> + * line length we're dealing with > >> + */ > >> protected int lineLength; > >> > >> - // number of deferred whitespace characters in decode mode. > >> + /** > >> + * number of deferred whitespace characters in decode mode. > >> + */ > >> protected int deferredWhitespace = 0; > >> > >> + /** > >> + * internal parsed character cache. > >> + */ > >> protected int cachedCharacter = -1; > >> > >> - // indicates whether the last character was a '\r', potentially > part > >> of a CRLF sequence. > >> + /** > >> + * indicates whether the last character was a '\r', potentially > part > >> of a CRLF sequence. > >> + */ > >> protected boolean lastCR = false; > >> > >> - // remember whether last character was a white space. > >> + /** > >> + * remember whether last character was a white space. > >> + */ > >> protected boolean lastWhitespace = false; > >> > >> public QuotedPrintableDecoder() { > >> > >> > >> > > > > > > -- > > http://people.apache.org/~britter/ > > http://www.systemoutprintln.de/ > > http://twitter.com/BenediktRitter > > http://github.com/britter > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
