Hi Simo,
2013/4/10 Simone Tripodi <simonetrip...@apache.org> > just an idea: the `test` prefix on methods signature can be now omitted, > since they are already marked with @Test > Yes, I agree (I liked that in BU2) but CSV still uses the old JUnit 3.x convention of prefixing tests with "test". I'm not sure whether it's a good idea to start mixing this styles. WDYT? > > my 0.0002 cents, > -Simo > > http://people.apache.org/~simonetripodi/ > http://simonetripodi.livejournal.com/ > http://twitter.com/simonetripodi > http://www.99soft.org/ > > > On Wed, Apr 10, 2013 at 7:48 PM, <brit...@apache.org> wrote: > > > Author: britter > > Date: Wed Apr 10 17:48:28 2013 > > New Revision: 1466591 > > > > URL: http://svn.apache.org/r1466591 > > Log: > > Give test a better name > > > > Modified: > > > > > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java > > > > Modified: > > > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java > > URL: > > > http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java?rev=1466591&r1=1466590&r2=1466591&view=diff > > > > > ============================================================================== > > --- > > > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java > > (original) > > +++ > > > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVLexerTest.java > > Wed Apr 10 17:48:28 2013 > > @@ -58,7 +58,7 @@ public class CSVLexerTest { > > } > > > > @Test > > - public void testIgnoreSurroundingSpacesAreDeleted() throws > > IOException { > > + public void testSurroundingSpacesAreDeleted() throws IOException { > > final String code = "noSpaces, leadingSpaces,trailingSpaces , > > surroundingSpaces , ,,"; > > final Lexer parser = getLexer(code, > > CSVFormat.newBuilder().withIgnoreSurroundingSpaces(true).build()); > > assertThat(parser.nextToken(new Token()), matches(TOKEN, > > "noSpaces")); > > > > > > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
