Hi again Rodion, I had a look at your patch at is simply *amazing* I have no words to say thank you for that great contribution! :) I just attached 2 observations to the issue, if you could re-submit the patch applying that 2 small request, it would be great.
I really hope you'll continue get involved in commons-graph!!! All the best, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Thu, May 16, 2013 at 3:07 PM, Rodion Efremov <rodion.efre...@cs.helsinki.fi> wrote: > Hello all. > > Have attached the patch containing bidirectional Dijkstra SSSP algo + tests > at org.apache.commons.graph.shortestpath (issue SANDBOX-457) in hope someone > will review it. The benchmark is telling: > applyingDijkstra(): time.warmup: 0.30, time.bench: 1.09 > applyingBidirectionalDijkstra(): time.warmup: 0.01, time.bench: 0.04 > both on the same connected graph and identical sequences of <source, target> > -pairs. > > Couple of questions: > (a) What is the average duration between sending a patch P and getting it > reviewed by a committer, assuming P will draw some attention eventually? > (b) Is it possible that a patch to a Sandbox component will be ignored for a > very looong time in favor of more important issues going on in *Commons > Proper*? > > -rodde > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
