On Thu, May 23, 2013 at 12:11 AM, Phil Steitz <[email protected]> wrote:
> On 5/22/13 1:19 PM, [email protected] wrote: > > Author: ggregory > > Date: Wed May 22 20:19:00 2013 > > New Revision: 1485398 > > > > URL: http://svn.apache.org/r1485398 > > Log: > > Remove rule that assumed DBCP 1.4 is on Java 1.4, it is on Java 6. > > -1 to this and the other 1.4-breaking changes in the 1.4 code. I > will move to -0 if someone volunteers to do the now manual > backporting work to cut a 1.3.1 if and when 1.4.1 is cut or we agree > to abandon 1.3.x altogether. See the file, release-process.txt in > the 1.4 branch. Bassically, the 1.3 branch is *automatically > generated* from the 1.4 branch, making it unnecessary to > individually backport bug fixes to 1.3. Breaking this creates lots > of manual work unless we drop 1.3 altogether. The > compatabilty-breaking changes are cosmetic, so I would recommend we > roll them back. > Fixed in SVN for Java 1.4 compat. The changes are NOT cosmetic BTW, they generated less garbage but require Java 5. Gary > Phil > > > > Modified: > > > commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml > > > > Modified: > commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml > > URL: > http://svn.apache.org/viewvc/commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml?rev=1485398&r1=1485397&r2=1485398&view=diff > > > ============================================================================== > > --- > commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml > (original) > > +++ > commons/proper/dbcp/branches/DBCP_1_4_x_BRANCH/findbugs-exclude-filter.xml > Wed May 22 20:19:00 2013 > > @@ -22,9 +22,4 @@ > > put here to instruct findbugs it must ignore them. > > --> > > <FindBugsFilter> > > - <!-- Minimum JDK level is still 1.4, so valueOf(int) is not > available --> > > - <Match> > > - <Class>*</Class> > > - <Bug pattern="DM_NUMBER_CTOR" /> > > - </Match> > > </FindBugsFilter> > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
