On Wed, Jun 19, 2013 at 3:12 AM, Julien Aymé <julien.a...@gmail.com> wrote:
> Hi everyone, > > I've used sshd from mina at work > (http://mina.apache.org/sshd-project/index.html), and I found the api > really attractive. > In sshd there is already a SFTP server implemented, but there is no > SFTP filesystem client support. > > So I am willing to take up the task of (re)implementing a SFTP > filesystem using sshd instead of jsch, for the following reasons: > - use our own food: sshd is hosted at apache. > - sshd code is clean and partially documented (at least more > documented than jsch code). > - I like it :) > - We are going to use it at work, since we noticed that using sshd > makes our code "faster" (not really faster, but there is less time > spent in Thread.sleep). > > My questions are: > - Is there any interest in VFS for it, or should I ask the sshd guys > if there are interrested ? > I do like the eating our own dog food argument. > - Is there a procedure for such task ? > Create a JIRA and attach a patch based on trunk, with unit tests. > - Is it okay to replace jsch dependency with another one ? > I would not do that, especially considering the sshd code is not 1.0 yet. What I would prefer seeing is a new package called org.apache.commons.vfs2.provider.sftp.sshd or org.apache.commons.vfs2.provider.sftp.mina. Ideally, the new impl would not touch the current one, for now. If the implementation is a success and accepted, we can then repackage the current org.apache.commons.vfs2.provider.sftp into org.apache.commons.vfs2.provider.sftp.jsch (in a major release) to keep it all neat and tidy. Then people can pick one. We can then deprecate jsch and remove the jsch version in a major release. > - annex: What are the coding conventions for VFS ? > Look at the source code in trunk. There are no pre-canned IDE config files to help sadly. I do not like the { } convention currently in use, but that's what we have now. It may change in the future of course. Gary > > > Regards, > Julien > > P.S.: Perhaps this should be shared on mina dev list as well, I don't know. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory