On 5 August 2013 18:46, Benedikt Ritter <brit...@apache.org> wrote: > 2013/8/5 Gary Gregory <garydgreg...@gmail.com> > >> In https://issues.apache.org/jira/browse/CSV-42 >> >> One of the comments is to make all classes final. >> >> Right now, only our package private types are final. >> >> Thoughts? >> > > Sounds reasonable (to make all classes final).
Agreed. It might turn out that some classes have to be extendable (and thus non-final), but that would be possible to change later. Whereas making a class final breaks API compat. Code should always start with minimum visibility etc. > Benedikt > > >> >> Gary >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> Java Persistence with Hibernate, Second Edition< >> http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> > > > > -- > http://people.apache.org/~britter/ > http://www.systemoutprintln.de/ > http://twitter.com/BenediktRitter > http://github.com/britter --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
