I quite like the idea of dropping the CSV prefix - the package name is csv so the CSV prefix is redundant.
But if no-one else is keen, it's not a big deal. On 7 August 2013 00:19, Gary Gregory <garydgreg...@gmail.com> wrote: > I think we can be done unless other opinions come in... > > G > > > On Tue, Aug 6, 2013 at 6:57 PM, sebb <seb...@gmail.com> wrote: > >> On 6 August 2013 17:47, Gary Gregory <garydgreg...@gmail.com> wrote: >> > On Tue, Aug 6, 2013 at 11:27 AM, Benedikt Ritter <brit...@apache.org> >> wrote: >> > >> >> 2013/8/6 sebb <seb...@gmail.com> >> >> >> >> > On 6 August 2013 15:48, Gary Gregory <garydgreg...@gmail.com> wrote: >> >> > > The class names in [csv] are (pp) means package private, others are >> >> > public >> >> > > >> >> > > org.apache.commons.csv.Constants (pp) >> >> > > org.apache.commons.csv.CSVFormat >> >> > > org.apache.commons.csv.CSVLexer >> >> > >> >> > That is also (pp) >> >> > >> >> > > org.apache.commons.csv.CSVParser >> >> > > org.apache.commons.csv.CSVPrinter >> >> > > org.apache.commons.csv.CSVRecord >> >> > > org.apache.commons.csv.ExtendedBufferedReader (pp) >> >> > > org.apache.commons.csv.Lexer (pp) >> >> > > org.apache.commons.csv.Quote >> >> > > org.apache.commons.csv.Token (pp) >> >> > > >> >> > > So all of the _public_ types except Quote are prefixed with "CSV". >> >> > > >> >> > > - Should all types be prefixed with "CSV"? >> >> > > - Should Quote be renamed to CSVQuote? >> >> > > >> >> > > - I personally, prefer the prefix "Csv", but I might be in the >> minority >> >> > > here. >> >> > >> >> > Could also rename Lexer as AbstractLexer and then drop all the CSV/Csv >> >> > prefixes. >> >> > >> >> > And/or possibly merge Lexer and CSVLexer. >> >> > >> >> >> >> big +1 from me. There is no need to have a package private abstract base >> >> class if we only have one package private implementation. >> >> >> > >> > Sebb just did this work, thank you Sebb! >> >> I only merged Lexer into CSVLexer. >> >> The naming issue (if it is one) still remains. >> >> > Gary >> > >> > >> >> >> >> >> >> > I think they were separated to make testing alternate implementations >> >> > easier. >> >> > But it's probably better to just copy all the relevant classes if we >> >> > need to revisit the benchmarks. >> >> > >> >> > > Gary >> >> > > >> >> > > -- >> >> > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> >> > > Java Persistence with Hibernate, Second Edition< >> >> > http://www.manning.com/bauer3/> >> >> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> >> > > Spring Batch in Action <http://www.manning.com/templier/> >> >> > > Blog: http://garygregory.wordpress.com >> >> > > Home: http://garygregory.com/ >> >> > > Tweet! http://twitter.com/GaryGregory >> >> > >> >> > --------------------------------------------------------------------- >> >> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> >> > For additional commands, e-mail: dev-h...@commons.apache.org >> >> > >> >> > >> >> >> >> >> >> -- >> >> http://people.apache.org/~britter/ >> >> http://www.systemoutprintln.de/ >> >> http://twitter.com/BenediktRitter >> >> http://github.com/britter >> >> >> > >> > >> > >> > -- >> > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> > Java Persistence with Hibernate, Second Edition< >> http://www.manning.com/bauer3/> >> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> > Spring Batch in Action <http://www.manning.com/templier/> >> > Blog: http://garygregory.wordpress.com >> > Home: http://garygregory.com/ >> > Tweet! http://twitter.com/GaryGregory >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second > Edition<http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
