On 10/20/13 4:33 AM, Gilles wrote: > Hi. > > On Sat, 19 Oct 2013 23:22:21 -0700, Phil Steitz wrote: >> I inadvertently committed some WIP on Kolmogorov-Smirnov test >> implementation (MATH-437) in r1533853, in which I meant only to fix >> some javadoc in BinomialConfidenceInterval. The commit copies the >> existing implementation from the distribution package and makes some >> mods to it. I did it this way to preserve history of the code that >> is being kept. The code is not finished, has some checkstyle >> issues, but it should build OK. I am not sure exactly how to undo >> this in svn so I can redo it later and I would prefer to just edit >> the commit log and finish the code that I was planning to commit >> later in subsequent commits. Are people OK with this, or should I >> try to back out the copy / add? > > IIUC the situation, what I do in such circumstances is > $ cp -i AddedFile.java AddedFile.java.NEW > $ svn del AddedFile.java > $ svn commit > > Then re-add the new file.
Sorry for the noise and screw-up. Above with copy thrown in will work. I just reverted. Thanks! Phil > >> [...] > > I notice that you changed back the uppercasing of the "@param" > Javadoc. I've a personal preference for having an uppercase letter > there, but I'd like that we fix the _project's_ preference. I > think that is important to have rules (yes, even trivial ones) > so that people (both committers and new contributors) can > unequivocally know what is expected in as many areas as possible. > This will reduce the amount of work for everyone. > [Sorry for the little hijacking of this thread.] > > > Thanks, > Gilles > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > . > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
