On 28 October 2013 19:14, <brit...@apache.org> wrote: > Author: britter > Date: Mon Oct 28 19:14:11 2013 > New Revision: 1536490 > > URL: http://svn.apache.org/r1536490 > Log: > If using more than one method name, the method elements have to be wrapped in > an Or element > > Modified: > commons/proper/lang/trunk/findbugs-exclude-filter.xml > > Modified: commons/proper/lang/trunk/findbugs-exclude-filter.xml > URL: > http://svn.apache.org/viewvc/commons/proper/lang/trunk/findbugs-exclude-filter.xml?rev=1536490&r1=1536489&r2=1536490&view=diff > ============================================================================== > --- commons/proper/lang/trunk/findbugs-exclude-filter.xml (original) > +++ commons/proper/lang/trunk/findbugs-exclude-filter.xml Mon Oct 28 19:14:11 > 2013 > @@ -51,8 +51,10 @@ > <!-- Reason: methods are supposed to fall back to default encoding if no > charset is specified -->
This is not documented in the code. I would make the default explicit, and drop the exclusion: For example: return new String(bytes, charset != null ? charset : Charset.defaultCharset()); This makes it clear that the default is intentional, and it agrees better with the Javadoc. > <Match> > <Class name="org.apache.commons.lang3.StringUtils" /> > - <Method name="toString" /> > + <Or> > + <Method name="toString" /> > <Method name="toEncodedString" /> > + </Or> > <Bug pattern="DM_DEFAULT_ENCODING" /> > </Match> > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
