I'd like to see more docs on why AbstractPatriciaTrie implements hashCode() but not equals(). I see that AbstractPatriciaTrie inherits equals from AbstractMap, but why not also inherit hashCode()? What is confusing is that AbstractPatriciaTrie's hashCode uses a MyEntryIterator but why not inherit the behavior when AbstractMap calls entrySet().iterator() in its own hashCode method?
If our behavior is correct, we need better docs. Gary On Tue, Nov 5, 2013 at 8:09 AM, Thomas Neidhart <[email protected]>wrote: > Hi, > > I'd like to call a vote for releasing Commons Collections 4.0 based on RC1. > > Changes since 4.0-alpha1 (copied from release-notes): > > o [COLLECTIONS-488] Added "CollectionsUtils#matchesAll(Iterable, > Predicate)" to test if all elements of a collection match a given > predicate. > o [COLLECTIONS-485] Accept wildcard input where possible, e.g. in > copy-constructors, Unmodifiable* decorators and iterators. > o [COLLECTIONS-481] No collision detection/resolution was performed > when calling "CompositeSet#addComposited(...)" > with more than one Set as argument. Additionally use varargs > parameters instead of arrays in CompositeSet and > CompositeCollection constructor and addComposited method. > o [COLLECTIONS-480] Narrow return type of "BidiMap#values()" to Set > as the values are required to be unique. > o [COLLECTIONS-468] Renamed CompliantBag to CollectionBag. > o [COLLECTIONS-475] Fixed conversion of timeout parameters in > "PassiveExpiringMap". > > Collections 4.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/collections/ > (svn revision 3420) > > Maven artifacts are here: > > > https://repository.apache.org/content/repositories/orgapachecommons-081/org/apache/commons/commons-collections4/4.0/ > > The tag is here: > > > https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC1/ > (svn revision 1538978) > > Site: > http://people.apache.org/builds/commons/collections/4.0/RC1/ > > Details of changes can be found in the release notes: > > > https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt > > > http://people.apache.org/builds/commons/collections/4.0/RC1/changes-report.html > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Note: the clirr report is generated against 4.0-alpha1 and it is also > highlighted in the release notes that this release is not compatible > with any previous release. > > Thank you for your reviews, > > Thomas > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
