Hi Jörg, thanks for your review.
Am 08.01.2014 10:55, schrieb Jörg Schaible: > Hi Oliver, > > README.txt is badly out of date, since it claims we ship commons-beanutils, > commons-beanutils-core and commons-beanutils-bean-collection. Good spot. I think the file can be removed completely. I will do this in trunk, but I hope there is no need to create another RC. The situation with the collections jars is also explained on the main site. Regarding the failing test cases: Most of them seem to be related to memory leak tests. I guess, here a special strategy is used which may well depend on the JDK. However, the tests affected have not been touched recently - certainly not for the 1.9.1 release and probably not for 1.9.0. So I assume the problems already existed in earlier releases. Oliver > > IBM JDK 5 fails badly: > > ========================= %< =========================== > Tests in error: > > org.apache.commons.beanutils.bugs.Jira347TestCase#testMappedPropertyDescriptor_AnyArgsProperty > > IllegalStateException > > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase#testPropertyUtilsBean_descriptorsCache_memoryLeak > > IllegalStateException > > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase#testPropertyUtilsBean_mappedDescriptorsCache_memoryLeak > > IllegalStateException > > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase#testMappedPropertyDescriptor_MappedMethodReference1 > > IllegalStateException > > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase#testMappedPropertyDescriptor_MappedMethodReference2 > > IllegalStateException > > org.apache.commons.beanutils.BeanificationTestCase#testMemoryTestMethodology > OutOfMemoryError > org.apache.commons.beanutils.BeanificationTestCase#testMemoryLeak2 > OutOfMemoryError > > org.apache.commons.beanutils.locale.LocaleBeanificationTestCase#testMemoryTestMethodology > > OutOfMemoryError > > org.apache.commons.beanutils.locale.LocaleBeanificationTestCase#testMemoryLeak2 > > OutOfMemoryError > > Tests run: 1269, Failures: 0, Errors: 9, Skipped: 0 > ========================= %< =========================== > > IBM JDK 6 fails with: > > ========================= %< =========================== > Failed tests: > > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase#testPropertyUtilsBean_descriptorsCache_memoryLeak > > AssertionFailedError > > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase#testPropertyUtilsBean_mappedDescriptorsCache_memoryLeak > > AssertionFailedError > > org.apache.commons.beanutils.memoryleaktests.MemoryLeakTestCase#testWrapDynaClass_dynaClasses_memoryLeak > > AssertionFailedError > > org.apache.commons.beanutils.DefaultIntrospectionContextTestCase#testAddPropertyDescriptors > > AssertionFailedError > > Tests run: 1269, Failures: 4, Errors: 0, Skipped: 0 > ========================= %< =========================== > > It builds fine with all tests succeeding for IBM JDK 7, IcedTea 6+7, Oracle > JDK 5-8. > > Cheers, > Jörg > > > Oliver Heger wrote: > >> Hi all, >> >> this is a vote to release Commons BeanUtils 1.9.1 based on RC1. This >> release fixes a problem with a new feature introduced in version 1.9.0. >> >> The distributions are available for review here: >> https://dist.apache.org/repos/dist/dev/commons/beanutils/ (svn >> revision 4057) >> >> Maven artifacts are here: >> >> > https://repository.apache.org/content/repositories/orgapachecommons-008/commons-beanutils/commons-beanutils/1.9.1/ >> >> Details of changes since 1.9.0 are in the release notes: >> >> https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txt >> >> The tag is here: >> >> > https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/BEANUTILS_1_9_1_RC1/ >> (svn revision 1555953) >> >> Site: >> http://people.apache.org/~oheger/beanutils-1.9.1-rc1/ >> (with some broken relative links) >> >> KEYS: >> http://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> This vote will close no sooner than 72 hours from now, i.e. after 2100 >> GMT 09-January 2014 >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thanks! >> >> Oliver > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org