Hello Stefan,
I've reviewed this RC using:
Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
17:22:22+0200)
Maven home: /usr/local/Cellar/maven/3.1.1/libexec
Java version: 1.7.0_45, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_45.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.9.1", arch: "x86_64", family: "mac"
- Signs and ashes look good (I need to sign your key as soon as we meet up
;-)
- archives have the same content
- source distribution has the same content as the tag
- reports and site look good
One minor thing I've noticed is, that the Build-By MANIFEST header is set
to "stefan". I've learned that it should be set to you're Apache ID. You
can achieve this by using -Duser.name=bodewig when calling mvn deploy. I've
already added this to the release publishing docs. A nice an easy way to
verify the correctness of MANIFEST.MF is putting:
manifest() { unzip -q -c "${1}" META-INF/MANIFEST.MF; }
into your .bash_profile. This is no show stopper to me.
When I build from sources, I get two errors: https://paste.apache.org/nEGh
You have already fixed those in trunk and building from trunk works for me.
Since this is was a problem with the test code and not with the production
code, this is no show stopper for me.
So here is my +1 for this RC.
Benedikt
2014/1/16 Stefan Bodewig <bode...@apache.org>
> Hi all
>
> compared to RC1 there is no code change only the Javadocs of the
> _internal package are even more discouraging and the directory tree
> insite the tarballs/zips should hold the correct version number.
>
> Compress 1.7 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/compress/
> (svn revision 4100)
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1002/org/apache/commons/commons-compress/1.7/
>
> Details of changes since 1.7 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/compress/RELEASE-NOTES.txt
> http://people.apache.org/~bodewig/cc-1.7/changes-report.html
>
> I have tested this with JDK 1.6 and 1.7 using maven3.
>
> The tag is here:
>
> http://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS-1.7-RC2/
> (svn revision 1558773)
>
> Site:
> http://people.apache.org/~bodewig/cc-1.7/
> (note I will create a Javadocs for 1.7, take a look at the trunk
> javadocs for now - and this is not going to be the website I'll
> publish after the release, I'll merge the canges made in the tag and
> build the site again from trunk)
>
> Clirr Report (compared to 1.6):
> http://people.apache.org/~bodewig/cc-1.7/clirr-report.html
>
> RAT Report:
> http://people.apache.org/~bodewig/cc-1.7/rat-report.html
>
> KEYS:
> http://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now, i.e. after 2000
> GMT 19-January 2014
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
--
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
