On 6 February 2014 16:09, Gary Gregory <garydgreg...@gmail.com> wrote: > On Thu, Feb 6, 2014 at 10:10 AM, Emmanuel Bourg <ebo...@apache.org> wrote: > >> If the 'p' prefix stands for 'parameter' in some Hungarian tradition you >> may want to rename pSizeMax to sizeMax as well for consistency. >> > > I'll have to think of a better general solution for the combo: > - It's not 'standard' in Java to use 'p' as a parameter name prefix. > - I do not want to fix this everywhere only to create compiler warnings for > a param name hidding an ivar name. > > So, in brief, a little more to think about.
BTW, in sone cases it's easier to change the field name. > Gary > >> >> Emmanuel Bourg >> >> >> Le 06/02/2014 15:51, ggreg...@apache.org a écrit : >> > Author: ggregory >> > Date: Thu Feb 6 14:51:59 2014 >> > New Revision: 1565292 >> > >> > URL: http://svn.apache.org/r1565292 >> > Log: >> > Better param names. >> > >> > Modified: >> > >> commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/LimitedInputStream.java >> > >> > Modified: >> commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/LimitedInputStream.java >> > URL: >> http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/LimitedInputStream.java?rev=1565292&r1=1565291&r2=1565292&view=diff >> > >> ============================================================================== >> > --- >> commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/LimitedInputStream.java >> (original) >> > +++ >> commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/LimitedInputStream.java >> Thu Feb 6 14:51:59 2014 >> > @@ -46,12 +46,12 @@ public abstract class LimitedInputStream >> > /** >> > * Creates a new instance. >> > * >> > - * @param pIn The input stream, which shall be limited. >> > + * @param inputStream The input stream, which shall be limited. >> > * @param pSizeMax The limit; no more than this number of bytes >> > * shall be returned by the source stream. >> > */ >> > - public LimitedInputStream(InputStream pIn, long pSizeMax) { >> > - super(pIn); >> > + public LimitedInputStream(InputStream inputStream, long pSizeMax) { >> > + super(inputStream); >> > sizeMax = pSizeMax; >> > } >> > >> > >> > >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second > Edition<http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
