2014-02-09 4:14 GMT+01:00 sebb <seb...@gmail.com>:

> On 8 February 2014 10:35, Benedikt Ritter <brit...@apache.org> wrote:
> > Hello Bernd,
> >
> > have a look at [1], point 2 in the Notes Section:
> >
> > "The SVN $Date$ keyword should not be used, because it relies on the
> > clients locale. Use the $Id$ keyword instead (see
> > http://markmail.org/message/zx4ii6pq4iin2tol)"
>
> The message actually says:
>
> >>>
> Please don't use $Date$ - it is rendered using the client Locale, and
> so causes problems matching SVN tags against source archives.
>
> $Revision$ is usally enough; if you really want a date, use $id$
> <<<
>
> > The Id svn keyword is important for release votes.
>
> Huh?
>
> The problem is that the $Date$ keyword makes comparing releases harder.
>
> Adding $Id$ does not help; it's only that it is better than using $Date$.
> Neither is necessary.
>
> > Since SVN will update
> > the keyword on every commit, you can simply diff the src distribution
> with
> > the release tag to make sure they match.
> > We have talked about migrating to git in the passed, but we haven't
> really
> > reached consensus about this. I don't know whether git will make keywords
> > obsolete, since a tag in git is immutable...
>
> Tags in SVN are also immutable (by convention).
>

Which means that they're not immutable :-)


>
> However SVN updates the working copy with the expansion of certain
> special strings.
> SVN keywords are a client feature.
>
> > HTH,
> > Benedikt
> >
> > [1] http://wiki.apache.org/commons/CodeStyle
> >
> >
> > 2014-02-08 Bernd Eckenfels <e...@zusammenkunft.net>:
> >
> >> Hello,
> >>
> >> while playing around with the git mirror (I compared the git clone with
> >> the SVN checkout) I noticed that a minority of SVN files (mostly
> >> javadoc comments in tests but also one constant in a sample) have an
> >> $ID$ comment which expands differently.
> >>
> >> Ironically there is also a
> >> rule about not using $Date$ in checkstyle.xml which is expanded.
> >>
> >> The later is a bug (as the rule does not work), but for consistency I
> >> also propose to remove the other IDs. What do people think?
> >>
> >> --- vfs/checkstyle.xml  2014-02-08 08:20:50.000000000 +0000
> >> ---
> >>
> >>
> vfs/core/src/main/java/org/apache/commons/vfs2/impl/DefaultFileSystemManager.java
> >> 2014-02-08 08:20:50.000000000 +0000 ---
> >>
> >>
> vfs/core/src/main/java/org/apache/commons/vfs2/provider/local/LocalFileRandomAccessContent.java
> >> 2014-02-08 08:20:49.000000000 +0000 ---
> >>
> >>
> vfs/core/src/main/java/org/apache/commons/vfs2/provider/sftp/IdentityRepositoryFactory.java
> >> 2014-02-08 08:20:49.000000000 +0000 ---
> >>
> >>
> vfs/core/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileObject.java
> >> 2014-02-08 08:20:49.000000000 +0000 ---
> >> vfs/core/src/main/java/org/apache/commons/vfs2/Resources.properties
> >> 2014-02-08 08:20:50.000000000 +0000 ---
> >>
> vfs/core/src/test/java/com/jcraft/jsch/TestIdentityRepositoryFactory.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >>
> >>
> vfs/core/src/test/java/org/apache/commons/vfs2/provider/http/test/HttpFilesCacheTestCase.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >>
> >>
> vfs/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >>
> >>
> vfs/core/src/test/java/org/apache/commons/vfs2/provider/local/test/ConversionTestCase.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >>
> >>
> vfs/core/src/test/java/org/apache/commons/vfs2/provider/ram/test/CustomRamProviderTest.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >>
> >>
> vfs/core/src/test/java/org/apache/commons/vfs2/provider/test/FileObjectSortTestCase.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >>
> >>
> vfs/core/src/test/java/org/apache/commons/vfs2/provider/UriParserTestCase.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >>
> >>
> vfs/core/src/test/java/org/apache/commons/vfs2/test/ProviderRandomReadTests.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >>
> >>
> vfs/core/src/test/java/org/apache/commons/vfs2/test/ProviderRandomReadWriteTests.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >>
> >>
> vfs/core/src/test/java/org/apache/commons/vfs2/test/ProviderRandomSetLengthTests.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >> vfs/core/src/test/java/org/apache/commons/vfs2/util/NHttpServer.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >> vfs/examples/src/main/java/org/apache/commons/vfs2/example/Shell.java
> >> 2014-02-08 08:20:48.000000000 +0000 ---
> >> vfs/findbugs-exclude-filter.xml     2014-02-08 08:20:50.000000000 +0000
> >>
> >> there are 2 empty directories missing in git, but I guess thats not a
> >> big problem:
> >>
> >> Only in vfs/core: jackrabbit
> >> Only in vfs/sandbox/src/test/java/org/apache/commons/vfs2/provider:
> >> webdav
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> >> For additional commands, e-mail: dev-h...@commons.apache.org
> >>
> >>
> >
> >
> > --
> > http://people.apache.org/~britter/
> > http://www.systemoutprintln.de/
> > http://twitter.com/BenediktRitter
> > http://github.com/britter
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Reply via email to