Go for it. Gary
<div>-------- Original message --------</div><div>From: Phil Steitz <[email protected]> </div><div>Date:04/12/2014 13:31 (GMT-05:00) </div><div>To: Commons Developers List <[email protected]> </div><div>Subject: [DBCP] changes in r </div><div> </div>The changes to TestConnectionPool to make findbugs happy in r 1572068 [1] eliminated the explicit close of resources, which I think is not a good practice to promote in the unit tests and it also makes the test harder to follow / modify. Sorry I missed this when the commit was made. Any objections to adding back the explicit close of the resultset, statement and connection objects created in the TestThread run method? Phil [1] http://s.apache.org/gIT --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
