On 5/17/14, 6:06 AM, Luc Maisonobe wrote: > Le 17/05/2014 01:04, Phil Steitz a écrit : >> DBCP 2.0.1 RC2 is available for review here: >> https://dist.apache.org/repos/dist/dev/commons/dbcp (r5371) >> >> Maven artifacts are here: >> https://repository.apache.org/content/repositories/orgapachecommons-1030/ >> >> Details of changes since 2.0 are in the release notes: >> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt >> >> The tag is here: >> http://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_2_0_1_RC2 >> (r1595381) >> >> Site: >> http://people.apache.org/~psteitz/dbcp/dbcp-2.0.1/ >> (Broken links to Javadoc versions expected) >> >> Clirr Report: >> http://people.apache.org/~psteitz/dbcp/dbcp-2.0.1/clirr-report.html >> >> RAT: >> http://people.apache.org/~psteitz/dbcp/dbcp-2.0.1/rat-report.html >> >> Please review the release candidate and vote. >> This vote will close no sooner that 72 hours from now >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [X] -0 OK, but really should fix... > A few image files (jpeg and xcf) seem to have been corrupted in both the > source tar.gz and source zip. The corruption is different in both > archives, and they are different to the files retrieved from subversion. > > Perhaps a line-ending conversion? > > The files are: > > static_structure_dia.gif > dbcp-logo-white.xcf > dbcp-logo-blue.jpg > dbcp-logo-white.png > AbandonedObjectPool.gif > BasicDataSource.gif > ConnectionFactory.gif > Delegating.gif > PoolingConnection.gif > PoolingDataSource.gif > createDataSource.gif > getConnection.gif > prepareStatement.gif > > The java source files from the .tar.gz also seem to have been stripped > of the last newline, so they generate one checkstyle error each. This is > different from what happens when building directly from the subversion tag. > > > Apart from this, compilation and tests runs fine on both the tag and the > tar.gz sources.
Thanks, Luc. Source distro different from tag is a blocker. I have no idea how this happened, as I built the distro from a fresh checkout of the tag. I will see if I can figure out what is going on and roll another RC. Thanks for reviewing. Phil > > Luc > >> [ ] -1 I oppose this release because... >> >> Thanks! >> >> Phil >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
