Ok, if you do not mind doing another release candidate, that is great. We should I add to the release notes that the software cannot be built with Java 8 due to a bug in FindBugs.
Gary <div>-------- Original message --------</div><div>From: Thomas Neidhart <thomas.neidh...@gmail.com> </div><div>Date:06/28/2014 10:37 (GMT-05:00) </div><div>To: Commons Developers List <dev@commons.apache.org> </div><div>Subject: Re: [VOTE] Release Email 1.3.3 based on RC1 </div><div> </div>On 06/28/2014 03:20 PM, Gary Gregory wrote: > Builds "mvn clean site" ok with: > > Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e; > 2014-06-17T09:51:42-04:00) > Maven home: C:\Java\apache-maven-3.2.2 > Java version: 1.7.0_60, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.7.0_60\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > > but not with: > > Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e; > 2014-06-17T09:51:42-04:00) > Maven home: C:\Java\apache-maven-3.2.2 > Java version: 1.8.0_05, vendor: Oracle Corporation > Java home: C:\Program Files\Java\jdk1.8.0_05\jre > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos" > > where I get: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 53.766s > [INFO] Finished at: Sat Jun 28 08:55:12 EDT 2014 > [INFO] Final Memory: 48M/203M > [INFO] > ------------------------------------------------------------------------ > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on > project commons-email: Error during page generation: Error rendering Maven > report: > [ERROR] Exit code: 1 - javadoc: warning - Error fetching URL: > http://docs.oracle.com/javase/6/docs/api > [ERROR] javadoc: warning - Error fetching URL: > http://docs.oracle.com/javaee/6/api > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\AbstractEmailTest.java:524: > warning: no @throws for java.lang.Exception > [ERROR] protected URL createInvalidURL() throws Exception { > [ERROR] ^ > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:553: > warning: no @throws for java.lang.Exception > [ERROR] public void testAddZipUrl() throws Exception > [ERROR] ^ > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:606: > warning: no @throws for java.lang.Exception > [ERROR] public void testCallingBuildMimeMessageBeforeSent() throws > Exception { > [ERROR] ^ > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:645: > error: element not closed: pre > [ERROR] * creates a plain content and HTML content using <pre> tags. > [ERROR] ^ > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:648: > warning: no @throws for org.apache.commons.mail.EmailException > [ERROR] public void testSendWithPlainTextButNoHtmlContent() throws > EmailException, IOException > [ERROR] ^ > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:648: > warning: no @throws for java.io.IOException > [ERROR] public void testSendWithPlainTextButNoHtmlContent() throws > EmailException, IOException > [ERROR] ^ > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:690: > warning: no @throws for java.lang.Exception > [ERROR] public void testEmbedFileWithCID() throws Exception > [ERROR] ^ > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\InvalidInternetAddressTest.java:80: > error: exception not thrown: java.lang.Exception > [ERROR] * @throws Exception on any error > [ERROR] ^ > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\MultiPartEmailTest.java:386: > error: unknown tag: todo > [ERROR] /** @todo implement test for GetContainer */ > [ERROR] ^ > [ERROR] > C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\SimpleEmailTest.java:78: > error: unknown tag: todo > [ERROR] * @todo Add code to test the popBeforeSmtp() settings > [ERROR] ^ > [ERROR] > [ERROR] Command line was: "C:\Program > Files\Java\jdk1.8.0_05\jre\..\bin\javadoc.exe" @options @packages > [ERROR] > [ERROR] Refer to the generated Javadoc files in > 'C:\temp\rc\commons-email-1.3.3-src\target\site\testapidocs' dir. > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, > please read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException > > So the claim to fix Java 8 Javadocs by > https://issues.apache.org/jira/browse/EMAIL-136 is not 100% complete. > > I fixed the Javadoc 8 errors in SVN. > > -0 because we claim to have fixed building Java 8 but we have not 100%. So > I think that if we recut an RC with my trunk changes OR drop EMAIL-136 as > claimed to be fixed, I would +1. I did not check email with java 8 and you did make the change wrt javadoc. If it is fine now, I am ok with cutting another RC. > FindBugs (the RC uses 2.5.2) blows up on Java 8: yes, this is a known issue since a few releases now. There is no findbugs version that is compatible with Java 8 afaik. Thats why it is more or less pointless to test our site build with Java 8 atm, you will always get an error. Testing compile, test and package would make sense otoh. Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org