Hello, I commented your PR, it should at least name the new method getMax not getMean, but IMHO there are other things possible to improve as well.
But what I am curious about: your congestion profile looks pretty severe. But the code itself is rather uncritical. Did you do a stress test on an empty implementation? Bernd Am 18.09.2014 11:00 schrieb "Lucas Pouzac (JIRA)" <[email protected]>: > Lucas Pouzac created POOL-277: > --------------------------------- > > Summary: Monitor contention at BaseGenericObjectPool > Key: POOL-277 > URL: https://issues.apache.org/jira/browse/POOL-277 > Project: Commons Pool > Issue Type: Improvement > Affects Versions: 2.2 > Reporter: Lucas Pouzac > Fix For: 2.3 > > > Updating JMX causes synchronization while the service is secondary. See > screenshot. > > I create a pull request to optimize a contention. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) >
