See comments here after. Le 4 nov. 2014 17:09, "Emmanuel Bourg" <ebo...@apache.org> a écrit : > > Le 04/11/2014 15:55, Jochen Wiedmann a écrit : > > > Any feedback welcome. > > Hi Jochen, > > I'm not a dependency injection expert so I can't really comment on the > design, I could just make trivial observations like the use of the 'I' > prefix for the interfaces which isn't used in the commons components and > may lead to some confusing names (IMutableBindingSource is not immutable).
+1 C++ like inheritance. Very old and usually not used. > I'm more concerned by the viability of this project as a Apache Commons > component: > - Are there other committers interested in maintaining this project? > - Will this be used by other Apache projects? I tend to see Apache > Commons as the place to factorize common code used across Apache > projects, I'm not sure it works very well in the other direction. > - I'm under the impression there are already well established > implementations of JSR 330, what was the motivation behind this > implementation? What are the selling points of this implementation > compared to the others? +1 And +1 for Romain as well. Contributing to openwebbeans would avoid splitting community and efforts. Moreover, owb already passes this 330 tck and more. It's well tested and integrated in various other apache projects and more. If it does not fit your needs you are more than welcome to contribute and every contribution is valuable. > - Why bringing this in Apache Commons instead of starting on Github? > > Emmanuel Bourg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org >
