I'll put taking a look at addRawArchiveEntry with ZipEntry on my todo list. I have quite a few threads converging into the last class already; but everything should be done in a few days now.
copyRawEntries could definitely be somewhere else. Originally I implemented it on ZipArchiveOutputStream, but it's really not that much better :) Kristian 2014-12-23 18:43 GMT+01:00 Stefan Bodewig <[email protected]>: > On 2014-12-18, <[email protected]> wrote: > >>> public void addRawArchiveEntry(ZipArchiveEntry entry, InputStream >>> rawStream) > > Technically entry could be a java.util.zip.ZipEntry, I'm not sure this > would open up new opportunities, though. > >>> /** >>> * Transfer selected entries from this zipfile to a given >>> #ZipArchiveOutputStream. >>> * Compression and all other attributes will be as in this file. >>> * This method transfers entries based on the central directory of the >>> zip file. >>> * >>> * @param target The zipArchiveOutputStream to write the entries to >>> * @param predicate A predicate that selects which entries to write >>> */ >>> public void copyRawEntries(ZipArchiveOutputStream target, >>> ZipArchiveEntryPredicate predicate) >>> throws IOException { > > I'm not entirely sure this should be an instance method of ZipFile, it > looks more like a utility method that could live outside of the class as > it doesn't need any of the non-public parts of it. > > Then again ZipUtil is a bag of pretty unrelated methods so it doesn't > sound like a happy place for it either. > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
