On 12/24/14 4:37 AM, Emmanuel Bourg wrote: > I observed 2 test failures on Windows with Java 6, 7 and 8 that didn't > happen with the previous version: > > Tests run: 58, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 156.641 > sec <<< FAILURE! - in > org.apache.commons.pool2.impl.TestGenericKeyedObjectPool > testClientWaitStats(org.apache.commons.pool2.impl.TestGenericKeyedObjectPool) > Time elapsed: 0.11 sec <<< FAILURE! > java.lang.AssertionError: null > at org.junit.Assert.fail(Assert.java:86) > at org.junit.Assert.assertTrue(Assert.java:41) > at org.junit.Assert.assertTrue(Assert.java:52) > at > org.apache.commons.pool2.impl.TestGenericKeyedObjectPool.testClientWaitStats(TestGenericKeyedObjectPool.java:1583) > > > Tests run: 70, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 73.891 > sec <<< FAILURE! - in org.apache.commons.pool2.impl.TestGenericObjectPool > testBorrowObjectFairness(org.apache.commons.pool2.impl.TestGenericObjectPool) > Time elapsed: 2.437 sec <<< FAILURE! > java.lang.AssertionError: Thread 36 failed: java.lang.Throwable: > Expected: 36 found: 37 > at org.junit.Assert.fail(Assert.java:88) > at > org.apache.commons.pool2.impl.TestGenericObjectPool.testBorrowObjectFairness(TestGenericObjectPool.java:2034)
Thanks for testing and reporting this. The failing test is new, verifying the fix for POOL-289. The test is too sensitive for the Windows system clock. It basically depends on the assumption that if a thread does sleep(100) then the difference between pre- post- system times is at least 100 ms. I will fix it and roll another RC (unless someone else with access to a Windows box wants to take a stab at it). Phil > > > The tests worked fine on Debian with OpenJDK 6 & 7 . > > Emmanuel Bourg > > > Le 23/12/2014 18:32, Phil Steitz a écrit : >> Tag: >> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_3_RC1/ >> >> Release: >> https://dist.apache.org/repos/dist/dev/commons/pool/ >> >> Maven: >> https://repository.apache.org/content/repositories/orgapachecommons-1070 >> >> Site: >> http://people.apache.org/~psteitz/pool/pool-2.3-rc1/ >> >> Release notes: >> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt >> >> Votes, please. This vote will close in 72 hours (26-Dec 17:30 GMT) >> >> [ ] +1 Release this >> [ ] +0 Ok, but... >> [ ] -0 Really should fix... >> [ ] -1 We should not release this RC >> >> Thanks! >> >> Phil >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
