I see you fixed this. Thanks.
Kristian 2015-01-11 19:58 GMT+01:00 Stefan Bodewig <[email protected]>: > On 2015-01-09, <[email protected]> wrote: > >> @@ -336,20 +338,48 @@ public class ZipArchiveEntry extends jav >> * @since 1.1 >> */ >> public ZipExtraField[] getExtraFields(boolean includeUnparseable) { >>+ return includeUnparseable ? >>+ getAllExtraFields() : >>+ getParseableExtraFields(); >>+ } > > This is inconsistent WRT copying arrays or returning the internal > structure. getAllExtraFields will create a copy of extraFields (unless > there has been unparseable data), but getParseableExtraFields() does > not. > > I think it would be good to always create copies here, maybe call the > no-arg version of getExtraFields instead of getParseableExtraFields? > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
