On 5/30/15 4:55 AM, sebb wrote: > On 30 May 2015 at 10:21, Luc Maisonobe <l...@spaceroots.org> wrote: >> Le 30/05/2015 01:35, Phil Steitz a écrit : >>> This is a vote to release version 2.4.1 of Apache Commons Pool based on >>> RC1. Version 2.4.1 is source-identical to 2.4 other than build >>> configuration (pom and findbugs filter). This release is to replace the >>> defective binary jar created due to a build plugin bug (see POOL-297). >>> >>> Here is the release candidate: >>> https://dist.apache.org/repos/dist/dev/commons/pool/ >>> (r9171) >>> >>> Built from: >>> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/ >>> (r1682493) >>> >>> Release notes: >>> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt >>> >>> Maven artifacts: >>> http://s.apache.org/M5m >>> >>> site: >>> http://people.apache.org/~psteitz/pool/pool-2.4.1-rc1 >>> (I will s/2.4/2.4.1 in the javadoc link post-release) >>> >>> keys: >>> >>> https://www.apache.org/dist/commons/KEYS >>> >>> Votes, please. >> When I regenerate the site from source distribution, I get 110 CLIRR >> errors, but I consider they are expected (and in fact they are the >> reason why this release is done). These errors are related to cobertura >> instrumentation having been removed betwee 2.4 and 2.4.1. >> I just don't understand why this did not show up in >> <http://people.apache.org/~psteitz/pool/pool-2.4.1-rc1/clirr-report.html>. > Perhaps because Phil's local Maven repo had the unadulterated version > of the 2.4 jar in it?
Yes, that's what happened. As part of my troubleshooting, I ended up installing a clean 2.4 jar locally. I think it is best, actually, to publish the site without the extraneous Clirr stuff, or to just generate it with 2.3 as the reference version if that is possible. In any case, that should not block the urgent action of getting a clean binary release out. Phil >> There is also one checkstyle error (missing header in a generated >> cobertura.properties file), but this should be considered a false >> positive as it is a generated file without any Apache IP and therefore >> is not expected to have an Apache header. >> >> >>> This vote will close in 24 hours if there are 3 +1 votes by that time. >>> >>> [X] +1 Release these artifacts >> Luc >> >>> [ ] +0 OK, but... >>> [ ] -0 OK, but really should fix... >>> [ ] -1 I oppose this release because... >>> >>> Thanks! >>> >>> Phil >>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
