Any thoughts on not using underscores in names?
Gary
---------- Forwarded message ----------
From: Sebb (JIRA) <j...@apache.org>
Date: Wed, Aug 12, 2015 at 5:52 AM
Subject: [jira] [Resolved] (BCEL-233) The access_flags field in AccessFlags
class should be final
To: iss...@commons.apache.org
[
https://issues.apache.org/jira/browse/BCEL-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved BCEL-233.
-----------------------
Resolution: Fixed
Fix Version/s: 6.0
URL: http://svn.apache.org/r1695497
Log:
BCEL-233 The access_flags field in AccessFlags class should be final
Modified:
commons/proper/bcel/trunk/src/changes/changes.xml
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AccessFlags.java
> The access_flags field in AccessFlags class should be final
> -----------------------------------------------------------
>
> Key: BCEL-233
> URL: https://issues.apache.org/jira/browse/BCEL-233
> Project: Commons BCEL
> Issue Type: Improvement
> Reporter: Sebb
> Fix For: 6.0
>
>
> The access_flags field in the AccessFlags class should be final.
> It is currently not set by any other classes outside their constructors.
> The public setters - e.g. isPrivate(boolean) - are not used and should be
deleted. [Apart from that, their names are really confusing.]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
--
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory
