Alternative to keep 100% BC - Remove the new method, release 2.5, and add it back for SNAPSHOT - Add the new method in a new sub-interface
Gary On Mon, Sep 21, 2015 at 10:23 AM, Phil Steitz <phil.ste...@gmail.com> wrote: > On 9/19/15 9:55 AM, sebb wrote: > > On 19 September 2015 at 17:26, Kristian Rosenvold <krosenv...@apache.org> > wrote: > >> 2015-09-19 13:58 GMT+02:00 Kristian Rosenvold <krosenv...@apache.org>: > >>> Just to be clear on this, the breach is adding an interface to > >> Oops. The breach is adding a /method/. > > That's what I assumed - adding a method to an interface does not > > affect binary compat. > > I am +1 for avoiding the repackaging if this is in fact very low > incidence, but calling it binary compatible is a bit of a stretch > (unless I am missing something), since it seems to me that this will > result in RTE if dropped in if a user supplies a listener that does > not implement the new method, which pretty much all "old" listeners > would not. So anyone who uses the listener *must* add the > implementation and recompile. Am I missing something here? > Definitely want to cover this in release notes, since for those who > use TailerListeners, unless they add the new method, they will get > unexpected RTE at EOF. > > Phil > > > >>> org.apache.commons.io.input.TailerListener#endOfFileReached > >>> and will probably only affect a few users. I'm documenting this in > >>> release notes. > >> Kristian > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
