I agree that applying this change blindly is not OK, we need a test. Gary
On Wed, Oct 7, 2015 at 10:13 AM, Benedikt Ritter <[email protected]> wrote: > Hello, > > we have this pull request [1] at github which proposed to change the way > ExtendedBufferedReader handles EOL. I currently don't understand the > implications of this change and the contributor has not provided a test > case that fails without this change. It like to here more opinions about > this change. The accompanying JIRA is here [2]. > > TIA, > Benedikt > > [1] https://github.com/apache/commons-csv/pull/5 > [2] https://issues.apache.org/jira/browse/CSV-158 > > > -- > http://people.apache.org/~britter/ > http://www.systemoutprintln.de/ > http://twitter.com/BenediktRitter > http://github.com/britter > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
