On 12/21/15 1:21 PM, Ole Ersoy wrote:
>
>
> On 12/21/2015 01:45 PM, Phil Steitz wrote:
>> On 12/21/15 12:26 PM, Ole Ersoy wrote:
>>>> Should look like this, with some typos fixed:
>>>>
>>>> /**
>>>> ...
>>>> * @throws MatrixDimensionMismatchException if the
>>>> dimensions of
>>>> * {@code destination} do not match those of {@code this}.
>>>> * @throws NumberIsTooSmallException if {@code endRow <
>>>> startRow} or
>>>> * {@code endColumn < startColumn}.
>>>> * @throws OutOfRangeException if the indices are not valid.
>>>> */
>>>> void copySubMatrix(int startRow, int endRow, int
>>>> startColumn,
>>>> int endColumn,
>>>> T[][] destination)
>>>> throws MatrixDimensionMismatchException,
>>>> NumberIsTooSmallException,
>>>> OutOfRangeException;
>>>>
>>>> I will fix this.
>>> I think it's easier to understand if the "too small" wording is
>>> included. Something like:
>>>
>>> @throws MatrixDimensionMismatchException if the {@code
>>> destination} matrix
>>> dimensions are too small.
>> No, the MatrixDimensionMismatchException is thrown whenever the
>> dimensions don't match exactly, as it says above.
> Maybe I'm missing something, but if that's the case then it seems
> like it would be better to just create and return the sub matrix
> internally and avoid the exception all together?
Sorry, I misread the code. You are correct. The @throws
MatrixDimensionMismatchException is wrong. AbstractFieldMatrix does
not check exact size - just throws if the destination does not have
enough rows or columns.
>
> The way I understand the method is that we have a matrix and we
> want the left hand corner of the matrix to be replaced with the
> submatrix being copied into it?
That is what AbstractFieldMatrix does. Thanks for pointing this out.
Phil
>
> Cheers,
> Ole
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
