Thanks for preparing this release candidate, Gary! My vote: +1 (binding)
Tested: +1 signatures, hashes +1 sources-jar vs src.zip +1 mvn clean install +1 mvn apache-rat:check +1 LICENSE, NOTICE (thanks!) +1 RELEASE-NOTES 0 Confusing file LICENSE-header.txt should not be in the src dist +1 mvn repository jar/gz/zip matches src/bin in dist 0 svn only matches src if I ignore whitespace (CRLF added in src archives) -- also src/test/**/CSVBenchmark.java is missing from src - why? +1 bin jar filenames match target jar Does CR vs CRLF make any difference for the CSV parsing and our test resources? Using just "svn co" in Ubuntu only these files are locked to have CRLF: stain@biggiebuntu:~/src/csv-1.4-rc2/svn$ find . -type f | xargs file |grep CRLF ./src/assembly/src.xml: exported SGML document, ASCII text, with CRLF line terminators ./src/assembly/bin.xml: exported SGML document, ASCII text, with CRLF line terminators ./src/test/resources/CSVFileParser/test.csv: ASCII text, with CRLF line terminators ./src/test/resources/CSVFileParser/testCSV85.csv: ASCII text, with CRLF line terminators ./src/test/java/org/apache/commons/csv/CSVFormatPredefinedTest.java: ASCII text, with CRLF line terminators Tested with: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) Maven home: /home/stain/software/maven Java version: 1.8.0_91, vendor: Oracle Corporation Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre Default locale: en_GB, platform encoding: UTF-8 OS name: "linux", version: "4.4.0-22-generic", arch: "amd64", family: "unix" On 25 May 2016 at 17:37, Stian Soiland-Reyes <st...@apache.org> wrote: > On 25 May 2016 at 05:20, Gary Gregory <garydgreg...@gmail.com> wrote: >> Apache Commons CSV 1.4 RC2 is available for review here: >> >> https://svn.apache.org/repos/asf/commons/proper/csv/tags/csv-1.4-RC2 >> (revision 1745420) > > Did you mean: > > https://dist.apache.org/repos/dist/dev/commons/csv/CSV_1_4_RC2/ > revision 13776 ? > > > > >> commons-csv-1.4-bin.tar.gz >> (SHA1: 620580a88953cbcf4528459e485054e7c27c0889) >> commons-csv-1.4-bin.zip >> (SHA1: b0060ed8397bfec39b397807f63e778618f324ce) >> commons-csv-1.4-src.tar.gz >> (SHA1: fac74d68fadad3e54025ac23a50c9559013d1b89) >> commons-csv-1.4-src.zip >> (SHA1: 047e0149af25c186969ea8ad2366e8ac6e2b2450) >> >> Maven artifacts are here: >> >> https://repository.apache.org/content/repositories/orgapachecommons-1175/org/apache/commons/commons-csv/1.4/ >> >> These are the artifacts and their hashes: >> >> commons-csv-1.4-test-sources.jar >> (SHA1: 494f6c95c3b00841436d158938249d81b1a7c200) >> commons-csv-1.4-sources.jar >> (SHA1: fde86fe0c44998b90a2a22ac038bc363121c9861) >> commons-csv-1.4.pom >> (SHA1: 28a9778fb5758d19187aad7537181486aeb40ca9) >> commons-csv-1.4.jar >> (SHA1: fc2512d2109144df353501266ac4bbe179058afd) >> commons-csv-1.4-javadoc.jar >> (SHA1: 4673391adc8a1f8a107a0a52bafed0618808a904) >> commons-csv-1.4-tests.jar >> (SHA1: 93124b682ceb24ac62af06d08736d430cf13fcb6) >> >> Details of changes since 1.3 are in the release notes: >> >> https://dist.apache.org/repos/dist/dev/commons/csv/CSV_1_4_RC2/RELEASE-NOTES.txt >> http://home.apache.org/~ggregory/csv-1.4-rc2/site/changes-report.html >> >> >> The tag is here: >> http://svn.apache.org/repos/asf/commons/proper/csv/tags/csv-1.4-RC2/ >> (revision 1745420) >> >> Site: >> http://home.apache.org/~ggregory/csv-1.4-rc2/site/ >> >> (some *relative* links are broken - these will be OK once the site >> is deployed) >> >> Clirr Report (compared to 1.3): >> http://home.apache.org/~ggregory/csv-1.4-rc2/site/clirr-report.html >> >> RAT Report: >> http://home.apache.org/~ggregory/csv-1.4-rc2/site/rat-report.html >> >> KEYS: >> https://www.apache.org/dist/commons/KEYS >> >> Please review the release candidate and vote. >> >> This vote will close no sooner than 72 hours from now, >> i.e. sometime after 23:00 PST 25 May 2016 >> >> >> [ ] +1 Release these artifacts >> [ ] +0 OK, but... >> [ ] -0 OK, but really should fix... >> [ ] -1 I oppose this release because... >> >> Thanks! >> Gary Gregory >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> Java Persistence with Hibernate, Second Edition >> <http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory > > > > -- > Stian Soiland-Reyes > Apache Commons, Apache Taverna (incubating), Apache Commons RDF (incubating) > http://orcid.org/0000-0001-9842-9718 -- Stian Soiland-Reyes Apache Commons, Apache Taverna (incubating), Apache Commons RDF (incubating) http://orcid.org/0000-0001-9842-9718 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
