> On Jun 27, 2016, at 3:18 AM, sebb <seb...@gmail.com> wrote: > > On 27 June 2016 at 09:09, Kristian Rosenvold <krosenv...@apache.org> wrote: >> This has probably been discussed a million times before, so I'll keep >> it short. commons-io has wonderfully inconsistent code style even >> within individual code files. >> >> Once the move to git completes, I'd like to reformat the entire code >> base (including javadoc) to a single style. I don't really care which >> style, my OCD is about consistency, not about which particular style >> is in use :) >> >> (Is there any kind of intelliJ code style file for commons ?) >> >> Sorry for disturbing the hornets :) > > -1
Really? You would veto the commit if it was done? > > This causes lots of grief when trying to track where a particular > section of code was introduced. Why? Just go through the history. No matter how the code has changed you can still tell when it was done. I’ve done this many times in Intellij and never had a problem. > > Likewise so does reorganising methods alphabetically. Although some people are big fans of this, rarely have I seen a code style document that actually requires it. > > If the code in a particular source file is really badly mangled then > it's worth standardising it internally, but IMO it's > counter-productive to reformat everything. I completely disagree and can sympathize with Kristian on this. That said, since I haven’t worked on the code in question I’ll shut up now. Ralph --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
